Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router[_builder]] drop pkg:all_lint_rules_community from pubspec #2623

Merged
merged 1 commit into from
Sep 21, 2022
Merged

[go_router[_builder]] drop pkg:all_lint_rules_community from pubspec #2623

merged 1 commit into from
Sep 21, 2022

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Sep 20, 2022

No description provided.

@kevmoo kevmoo requested a review from johnpryan September 20, 2022 02:10
@kevmoo kevmoo force-pushed the remove_all_lint_rules_community branch from 8d1d1d9 to a898f3c Compare September 20, 2022 23:50
@kevmoo kevmoo requested a review from chunhtai September 20, 2022 23:54
@kevmoo
Copy link
Contributor Author

kevmoo commented Sep 21, 2022

Reviewer: please add override: no versioning needed label. There are ZERO user facing changes here!

@chunhtai chunhtai added the override: no versioning needed Override the check requiring version bumps for most changes label Sep 21, 2022
chunhtai
chunhtai approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo removed the request for review from johnpryan September 21, 2022 00:19
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2022
@auto-submit auto-submit bot merged commit 4d1d631 into main Sep 21, 2022
@auto-submit auto-submit bot deleted the remove_all_lint_rules_community branch September 21, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: go_router_builder p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @chunhtai