Skip to content

Fix for RMS parsing #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jul 20, 2022
Merged

Fix for RMS parsing #2347

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b46545
Fix for RMS parsing
dnfield Jul 20, 2022
54e50dc
versions
dnfield Jul 20, 2022
26b4215
make version check happy...
dnfield Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/metrics_center/lib/src/google_benchmark.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void _parseAnItem(
) {
final String name = item[kNameKey] as String;
final Map<String, String> timeUnitMap = <String, String>{
kUnitKey: item[_kTimeUnitKey] as String
if (item.containsKey(_kTimeUnitKey)) kUnitKey: item[_kTimeUnitKey] as String
};
for (final String subResult in item.keys) {
if (!_kNonNumericalValueSubResults.contains(subResult)) {
Expand Down
27 changes: 27 additions & 0 deletions packages/metrics_center/test/example_google_benchmark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,33 @@
"real_coefficient": 6548,
"big_o": "N",
"time_unit": "ns"
},
{
"name": "ParagraphFixture/TextBigO_BigO",
"family_index": 5,
"per_family_instance_index": 0,
"run_name": "ParagraphFixture/TextBigO",
"run_type": "aggregate",
"repetitions": 1,
"threads": 1,
"aggregate_name": "BigO",
"aggregate_unit": "time",
"cpu_coefficient": 3.8,
"real_coefficient": 3.89,
"big_o": "N",
"time_unit": "ns"
},
{
"name": "ParagraphFixture/TextBigO_RMS",
"family_index": 5,
"per_family_instance_index": 0,
"run_name": "ParagraphFixture/TextBigO",
"run_type": "aggregate",
"repetitions": 1,
"threads": 1,
"aggregate_name": "RMS",
"aggregate_unit": "percentage",
"rms": 4.89
}
]
}
7 changes: 5 additions & 2 deletions packages/metrics_center/test/google_benchmark_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ void main() {
test('GoogleBenchmarkParser parses example json.', () async {
final List<MetricPoint> points =
await GoogleBenchmarkParser.parse('test/example_google_benchmark.json');
expect(points.length, 6);
expect(points.length, 9);
expectSetMatch(
points.map((MetricPoint p) => p.value),
<int>[101, 101, 4460, 4460, 6548, 6548],
<double>[101, 101, 4460, 4460, 6548, 6548, 3.8, 3.89, 4.89],
);
expectSetMatch(
points.map((MetricPoint p) => p.tags[kSubResultKey]),
Expand All @@ -25,6 +25,7 @@ void main() {
'real_time',
'cpu_coefficient',
'real_coefficient',
'rms',
],
);
expectSetMatch(
Expand All @@ -33,6 +34,8 @@ void main() {
'BM_PaintRecordInit',
'SkParagraphFixture/ShortLayout',
'SkParagraphFixture/TextBigO_BigO',
'ParagraphFixture/TextBigO_BigO',
'ParagraphFixture/TextBigO_RMS',
],
);
for (final MetricPoint p in points) {
Expand Down