Skip to content

Add enabled flag for try builders #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keyonghan merged 2 commits into from
Aug 13, 2020
Merged

Add enabled flag for try builders #189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5f626
add enabled flag
keyonghan Aug 12, 2020
0d536dd
update doc
keyonghan Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ for packages. It follows format:
"builders":[
{
"name":"xxx",
"repo":"packages"
"repo":"packages",

@godofredoc godofredoc Aug 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably change name to yyy?

@keyonghan keyonghan Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only one builder is listed in the doc. I guess we can use xxx.

"enabled":true
}
]
}
```
This file will be mainly used in [`flutter/cocoon`](https://github.com/flutter/cocoon)
to update luci task statuses of packages pre-submit tests.

This file will be mainly used in [`flutter/cocoon`](https://github.com/flutter/cocoon)
to trigger/update pre-submit luci tasks.
3 changes: 2 additions & 1 deletion dev/try_builders.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"builders":[
{
"name":"fuchsia_ctl",
"repo":"packages"
"repo":"packages",
"enabled":true
}
]
}