Skip to content

Add timeout to tar command and exit if it doesn't succeed. #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
godofredoc merged 2 commits into from
May 14, 2020
Merged

Add timeout to tar command and exit if it doesn't succeed. #156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3052549
Add timeout to tar command and exit if it doesn't succeed.
godofredoc May 13, 2020
76cedb5
Add tests and reduce timeout to 5 mins.
godofredoc May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/fuchsia_ctl/bin/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,12 @@ Future<OperationResult> pushPackages(

stdout.writeln('Untaring $repoArchive to ${repo.path}');
repo.createSync(recursive: true);
await tar.untar(repoArchive, repo.path);
final OperationResult result = await tar.untar(repoArchive, repo.path);
if (!result.success) {
stdout.writeln(
'Error untarring $repoArchive \nstdout: ${result.info} \nstderr: ${result.error}');
exit(-1);
}

final String repositoryBase = path.join(repo.path, 'amber-files');
stdout.writeln('Serving $repositoryBase to $targetIp');
Expand Down
4 changes: 2 additions & 2 deletions packages/fuchsia_ctl/lib/src/tar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ class SystemTar implements Tar {
) async {
final ProcessResult result = await processManager.run(<String>[
'tar',
'-xvf', src, //
'-xf', src, //
'-C', destination,
]);
]).timeout(const Duration(minutes: 10));

@dnfield dnfield May 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how long this takes on average? Would it really ever come close to 5? This seems long.

@godofredoc godofredoc May 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on my machine it is ~0.5 mins setting the default to 5.

Test for the tar.dart change?

Done


return OperationResult.fromProcessResult(result);
}
Expand Down