Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,18 @@ ${_indentation}The first version listed in CHANGELOG.md is $fromChangeLog.
errors.add('pubspec.yaml version changed');
}
}

final bool hasPromote = allChangelogs.any(
(PendingChangelogEntry entry) => entry.version == VersionChange.promote,
);
if (hasPromote) {
final Version version = package.parsePubspec().version!;
if (version.major != 0) {
printError('"promote" is only valid for pre-1.0 packages.');
errors.add('Invalid promote version change for post-1.0 package');
}
}
Comment thread
chunhtai marked this conversation as resolved.

return versionChanged;
}

Expand Down
89 changes: 89 additions & 0 deletions script/tool/test/validate_command_version_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1836,6 +1836,95 @@ packages/package/pending_changelogs/some_change.yaml

expect(output, containsAllInOrder(<Matcher>[contains('No issues found!')]));
});

test('fails for batch release package with version promote on post-1.0 package', () async {
final RepositoryPackage package = createFakePackage(
'package',
packagesDir,
version: '1.0.0',
);
package.ciConfigFile.writeAsStringSync('''
release:
batch: true
''');
package.libDirectory.childFile('foo.dart').writeAsStringSync('void foo() {}');
final Directory pendingChangelogs = package.directory.childDirectory('pending_changelogs');
pendingChangelogs.createSync();
pendingChangelogs.childFile('some_change.yaml').writeAsStringSync('''
changelog: "Promoting"
version: promote
''');

gitProcessRunner.mockProcessesForExecutable['git-diff'] = <FakeProcessInfo>[
FakeProcessInfo(
MockProcess(
stdout: '''
packages/package/lib/foo.dart
packages/package/pending_changelogs/some_change.yaml
''',
),
),
];
gitProcessRunner.mockProcessesForExecutable['git-show'] = <FakeProcessInfo>[
FakeProcessInfo(MockProcess(stdout: 'version: 1.0.0')),
];

Error? commandError;
final List<String> output = await runCapturingPrint(
runner,
<String>['validate', '--base-sha=main', '--check-for-missing-changes'],
errorHandler: (Error e) {
commandError = e;
},
);

expect(commandError, isA<ToolExit>());
expect(
output,
containsAllInOrder(<Matcher>[contains('"promote" is only valid for pre-1.0 packages.')]),
);
});

test('passes for batch release package with version promote on pre-1.0 package', () async {
final RepositoryPackage package = createFakePackage(
'package',
packagesDir,
version: '0.9.0',
);
package.ciConfigFile.writeAsStringSync('''
release:
batch: true
''');
package.libDirectory.childFile('foo.dart').writeAsStringSync('void foo() {}');
final Directory pendingChangelogs = package.directory.childDirectory('pending_changelogs');
pendingChangelogs.createSync();
pendingChangelogs.childFile('some_change.yaml').writeAsStringSync('''
changelog: "Promoting"
version: promote
''');

gitProcessRunner.mockProcessesForExecutable['git-diff'] = <FakeProcessInfo>[
FakeProcessInfo(
MockProcess(
stdout: '''
packages/package/lib/foo.dart
packages/package/pending_changelogs/some_change.yaml
''',
),
),
];
gitProcessRunner.mockProcessesForExecutable['git-show'] = <FakeProcessInfo>[
FakeProcessInfo(MockProcess(stdout: 'version: 0.9.0')),
];

final List<String> output = await runCapturingPrint(runner, <String>[
'validate',
'--base-sha=main',
'--check-for-missing-changes',
]);

expect(output, containsAllInOrder(<Matcher>[contains('No issues found!')]));
});
});
});

Expand Down
Loading