Skip to content

[animations] added onClosed #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goderbauer merged 7 commits into from
Apr 22, 2020
Merged

[animations] added onClosed #122

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
459f575
added onClosed
Mar 22, 2020
d036938
fixed null call issue
Mar 22, 2020
189ac17
remove space
Apr 4, 2020
b1fe750
added test
Apr 4, 2020
5434beb
ensure that callback isn't called to early
Apr 12, 2020
82cd934
fix typo
Apr 16, 2020
a3bd22b
Merge pull request #1 from flutter/master
The-Redhat Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/animations/lib/src/open_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class OpenContainer extends StatefulWidget {
borderRadius: BorderRadius.all(Radius.circular(4.0)),
),
this.openShape = const RoundedRectangleBorder(),
this.onClosed,
@required this.closedBuilder,
@required this.openBuilder,
this.tappable = true,
Expand Down Expand Up @@ -163,6 +164,9 @@ class OpenContainer extends StatefulWidget {
/// * [Material.shape], which is used to implement this property.
final ShapeBorder openShape;

/// Called when the container was popped and has returned to the closed state
Comment thread
The-Redhat marked this conversation as resolved.
Outdated
final VoidCallback onClosed;

/// Called to obtain the child for the container in the closed state.
///
/// The [Widget] returned by this builder is faded out when the container
Expand Down Expand Up @@ -220,8 +224,8 @@ class _OpenContainerState extends State<OpenContainer> {
// same widget included in the [_OpenContainerRoute] where it fades out.
final GlobalKey _closedBuilderKey = GlobalKey();

void openContainer() {
Navigator.of(context).push(_OpenContainerRoute(
Future<void> openContainer<T>() async {
await Navigator.of(context).push(_OpenContainerRoute(
closedColor: widget.closedColor,
openColor: widget.openColor,
closedElevation: widget.closedElevation,
Expand All @@ -235,6 +239,9 @@ class _OpenContainerState extends State<OpenContainer> {
transitionDuration: widget.transitionDuration,
transitionType: widget.transitionType,
));
if (widget.onClosed != null){
widget.onClosed();
}
}

@override
Expand Down Expand Up @@ -287,6 +294,7 @@ class _HideableState extends State<_Hideable> {
/// When non-null the child is replaced by a [SizedBox] of the set size.
Size get placeholderSize => _placeholderSize;
Size _placeholderSize;

Comment thread
The-Redhat marked this conversation as resolved.
Outdated
set placeholderSize(Size value) {
if (_placeholderSize == value) {
return;
Expand All @@ -302,6 +310,7 @@ class _HideableState extends State<_Hideable> {
/// (i.e. [isInTree] returns false).
bool get isVisible => _visible;
bool _visible = true;

Comment thread
The-Redhat marked this conversation as resolved.
Outdated
set isVisible(bool value) {
assert(value != null);
if (_visible == value) {
Expand Down