-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[camera_android_camerax] Add AGENTS.md
#12066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5b2cb6a
first draft
camsim99 5248366
rewrite draft
camsim99 ad19064
nit
camsim99 773288c
focus draft
camsim99 80aa881
wording
camsim99 aea5aa1
add pre-push skill and other lessons learned from project
camsim99 7f90a49
self review
camsim99 f3c75ec
Merge remote-tracking branch 'upstream/main' into cos_agentsmd
camsim99 9029420
bump version
camsim99 0af9ff1
Apply suggestions from code review
camsim99 c28c0d3
address review
camsim99 d7c4978
Apply suggestions from code review
camsim99 6ccf797
Merge remote-tracking branch 'refs/remotes/origin/cos_agentsmd' into …
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Agent Guide for camera_android_camerax | ||
|
|
||
| ## Core Workflows | ||
|
|
||
| - **Check Environment**: Run [check-readiness](.agents/skills/check-readiness/SKILL.md) | ||
| when starting a new task or if you suspect environment issues. | ||
| - **Regenerate Code**: | ||
| - Pigeon (`dart run pigeon --input pigeons/camerax_library.dart`): Run after | ||
| modifying `pigeons/camerax_library.dart`. | ||
| - Mocks (`dart run build_runner build -d`): Run after modifying mocked | ||
| classes or adding new mocks. (see [dart-generate-test-mocks](.agents/skills/dart-generate-test-mocks/SKILL.md)) | ||
| - **Verify Tests**: All tests must pass before landing. Add or update tests for | ||
| any new logic. For integration tests, see [flutter-add-integration-test](.agents/skills/flutter-add-integration-test/SKILL.md). | ||
| - **Run Pre-Push Checks**: Run [pre-push-skill](.agents/skills/pre-push-skill/SKILL.md) | ||
| before pushing to prevent CI failures and code review blocks. | ||
|
|
||
| ## Agent Guidelines | ||
|
|
||
| - Use [receiving-code-review](.agents/skills/receiving-code-review/SKILL.md) | ||
| to technically verify review feedback before blindly implementing suggestions, | ||
| especially if feedback seems technically questionable. | ||
| - Use `/grill-me` or `/plan` for complex features before writing code. | ||
| - Maintain high test coverage using [dart-add-unit-test](.agents/skills/dart-add-unit-test/SKILL.md) | ||
| and [dart-collect-coverage](.agents/skills/dart-collect-coverage/SKILL.md). | ||
| - Avoid duplicating constant strings; reuse existing ones from adjacent code. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level feedback this is much longer than an initial draft I thinks should be. Following the guidance in https://www.kaggle.com/whitepaper-the-new-SDLC-with-vibe-coding I think we should try to make this as short as we can since every token is an overhead in every conversation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have gone extreme in the other direction but the agent I edited with made it seem like I can get rid of all the wordiness and focus on the core operations/skills it needs to know so edited it down to this. PTAL!