Skip to content

[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle #11982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jul 1, 2026
Merged

[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle #11982

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7c0a62
Migrate segmented_control_test.dart to SemanticsHandle
Jun 25, 2026
db404a0
clean up
Jun 25, 2026
4cf3960
remove ensureSemantics
Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 59 additions & 81 deletions ...isabled_tests/segmented_control_test.dart → ...rtino_ui/test/segmented_control_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@Skip(
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
)
// This file is run as part of a reduced test set in CI on Mac and Windows
// machines.
@Tags(<String>['reduced-test-set'])
Expand All @@ -19,8 +16,6 @@ import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';

import '../widgets/semantics_tester.dart';

RenderBox getRenderSegmentedControl(WidgetTester tester) {
return tester.allRenderObjects.firstWhere((RenderObject currentObject) {
return currentObject.toStringShort().contains('_RenderSegmentedControl');
Expand Down Expand Up @@ -813,8 +808,6 @@ void main() {
});

testWidgets('Segmented control semantics', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);

final children = <int, Widget>{};
children[0] = const Text('Child 1');
children[1] = const Text('Child 2');
Expand All @@ -841,91 +834,76 @@ void main() {
),
);

// Assert parent role.
final SemanticsNode segmentedControlNode = tester.getSemantics(
find.byType(CupertinoSegmentedControl<int>),
);
expect(segmentedControlNode.role, ui.SemanticsRole.radioGroup);

// Assert Child 1 (selected).
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics.rootChild(
role: SemanticsRole.radioGroup,
children: <TestSemantics>[
TestSemantics(
label: 'Child 1',
flags: <SemanticsFlag>[
SemanticsFlag.isButton,
SemanticsFlag.isInMutuallyExclusiveGroup,
SemanticsFlag.hasSelectedState,
SemanticsFlag.isSelected,
SemanticsFlag.isFocusable,
],
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
),
TestSemantics(
label: 'Child 2',
flags: <SemanticsFlag>[
SemanticsFlag.isButton,
SemanticsFlag.isInMutuallyExclusiveGroup,
// Declares that it is selectable, but not currently selected.
SemanticsFlag.hasSelectedState,
SemanticsFlag.isFocusable,
],
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
),
],
),
],
),
ignoreId: true,
ignoreRect: true,
ignoreTransform: true,
find.semantics.byLabel('Child 1'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 1'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

isSemantics(
label: 'Child 1',
isButton: true,
isInMutuallyExclusiveGroup: true,
hasSelectedState: true,
isSelected: true,
isFocusable: true,
hasTapAction: true,
hasFocusAction: true,
),
);

// Assert Child 2 (unselected).
expect(
find.semantics.byLabel('Child 2'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 2'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

isSemantics(
label: 'Child 2',
isButton: true,
isInMutuallyExclusiveGroup: true,
hasSelectedState: true,
isSelected: false,
isFocusable: true,
hasTapAction: true,
hasFocusAction: true,
),
);

// Tap Child 2
await tester.tap(find.text('Child 2'));
await tester.pump();

// Assert Child 1 (now unselected).
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics.rootChild(
role: SemanticsRole.radioGroup,
children: <TestSemantics>[
TestSemantics(
label: 'Child 1',
flags: <SemanticsFlag>[
SemanticsFlag.isButton,
SemanticsFlag.isInMutuallyExclusiveGroup,
// Declares that it is selectable, but not currently selected.
SemanticsFlag.hasSelectedState,
SemanticsFlag.isFocusable,
],
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
),
TestSemantics(
label: 'Child 2',
flags: <SemanticsFlag>[
SemanticsFlag.isButton,
SemanticsFlag.isInMutuallyExclusiveGroup,
SemanticsFlag.hasSelectedState,
SemanticsFlag.isSelected,
SemanticsFlag.isFocusable,
SemanticsFlag.isFocused,
],
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
),
],
),
],
),
ignoreId: true,
ignoreRect: true,
ignoreTransform: true,
find.semantics.byLabel('Child 1'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 1'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

isSemantics(
label: 'Child 1',
isButton: true,
isInMutuallyExclusiveGroup: true,
hasSelectedState: true,
isSelected: false,
isFocusable: true,
hasTapAction: true,
hasFocusAction: true,
),
);

semantics.dispose();
// Assert Child 2 (now selected and focused).
expect(
find.semantics.byLabel('Child 2'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 2'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

isSemantics(
label: 'Child 2',
isButton: true,
isInMutuallyExclusiveGroup: true,
hasSelectedState: true,
isSelected: true,
isFocusable: true,
isFocused: true,
hasTapAction: true,
hasFocusAction: true,
),
);
});

testWidgets('Non-centered taps work on smaller widgets', (WidgetTester tester) async {
Expand Down
Loading