Skip to content

[material_ui] Remove widgets import in scaffold_test.dart #11973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jun 25, 2026
Merged

[material_ui] Remove widgets import in scaffold_test.dart #11973

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdcfc0f
Remove widgets import
QuncCccccc Jun 24, 2026
daa9a23
Move the file to test folder
QuncCccccc Jun 24, 2026
5cc4ae9
Fix linux analyze stable
QuncCccccc Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...orarily_disabled_tests/scaffold_test.dart → packages/material_ui/test/scaffold_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@Skip(
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
)
import 'dart:async' show unawaited;
import 'dart:math' as math;

import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart' show DragStartBehavior;
import 'package:material_ui/material_ui.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
import 'package:material_ui/material_ui.dart';

import '../widgets/semantics_tester.dart';
import 'semantics_tester.dart';

// From bottom_sheet.dart.
const Duration _bottomSheetExitDuration = Duration(milliseconds: 200);
Expand Down Expand Up @@ -1081,7 +1079,7 @@ void main() {
};
await tester.pumpWidget(MaterialApp(routes: routes));

Navigator.pushNamed(rootKey.currentContext!, '/scaffold');
unawaited(Navigator.pushNamed(rootKey.currentContext!, '/scaffold'));

@chunhtai chunhtai Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a warning for this change?

@chunhtai chunhtai Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should remove the unawaited here just to make our coding style in sync.

@Piinks Piinks Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be required. I think it was staged in flutter/flutter and waiting on the code freeze. The lint might be enabled in flutter/packages, where it's still pending in flutter/flutter. flutter/flutter#168555

@QuncCccccc QuncCccccc Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there was 2 failures in linux_analyze_stable test if we don't remove it.

await tester.pump();
await tester.pump(const Duration(seconds: 1));

Expand Down Expand Up @@ -1125,7 +1123,7 @@ void main() {
),
);

tester.state<NavigatorState>(find.byType(Navigator)).push(routeBuilder());
unawaited(tester.state<NavigatorState>(find.byType(Navigator)).push(routeBuilder()));

await tester.pump();
await tester.pump(const Duration(seconds: 1));
Expand Down
Loading