Skip to content

[pigeon] Adds support for analyzer 10 #11346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Mar 26, 2026
Merged

[pigeon] Adds support for analyzer 10 #11346

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6de9076
Update analyzer to support 10.0.0
tarrinneal Mar 25, 2026
930e774
allow use of analyzer 10
tarrinneal Mar 25, 2026
5329611
fix broken parent class assumptions
tarrinneal Mar 25, 2026
f5cf116
Merge branch 'main' of https://github.com/flutter/packages into ana-10
tarrinneal Mar 26, 2026
7a4b14a
nit
tarrinneal Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pigeon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 26.3.2

* Updates `analyzer` dependency to support version 10.0.0.
Comment thread
tarrinneal marked this conversation as resolved.
Resolved

## 26.3.1

* Fixes dartdoc comments that accidentally used HTML.
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/lib/src/generator_tools.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import 'generator.dart';
/// The current version of pigeon.
///
/// This must match the version in pubspec.yaml.
const String pigeonVersion = '26.3.1';
const String pigeonVersion = '26.3.2';

/// Default plugin package name.
const String defaultPluginPackageName = 'dev.flutter.pigeon';
Expand Down
8 changes: 6 additions & 2 deletions packages/pigeon/lib/src/pigeon_lib_internal.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,10 +1922,14 @@ class RootBuilder extends dart_ast_visitor.RecursiveAstVisitor<Object?> {
// resolved return type, via
// `node.declaredFragment!.element.returnType`.
String erroneousDeclaration = node.name.lexeme;
final dart_ast.AstNode? enclosingDeclaration = node.parent;
dart_ast.AstNode? enclosingDeclaration = node.parent;
while (enclosingDeclaration != null &&
enclosingDeclaration is! dart_ast.ClassDeclaration) {
enclosingDeclaration = enclosingDeclaration.parent;
}
if (enclosingDeclaration is dart_ast.ClassDeclaration) {
erroneousDeclaration =
'${enclosingDeclaration.name}.$erroneousDeclaration';
'${enclosingDeclaration.name.lexeme}.$erroneousDeclaration';
}
_errors.add(
Error(
Expand Down
5 changes: 3 additions & 2 deletions packages/pigeon/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
version: 26.3.1 # This must match the version in lib/src/generator_tools.dart
version: 26.3.2 # This must match the version in lib/src/generator_tools.dart

environment:
sdk: ^3.9.0

dependencies:
analyzer: ">=8.0.0 <10.0.0"
analyzer: ">=8.0.0 <11.0.0"
args: ^2.5.0
code_builder: ^4.10.0
collection: ^1.15.0
Expand All @@ -27,3 +27,4 @@ topics:
- interop
- platform-channels
- plugin-development

Loading