[Camera Plugin] Enhance camera functionality and support for transformations by Depdx · Pull Request #11231 · flutter/packages

Depdx · 2026-03-11T21:11:20Z

This update improves the camera plugin by adding support for lens position control, geometric transformations, and enhanced error handling. It also refactors the API for better clarity and performance, while updating dependencies to ensure compatibility with the latest Flutter versions. This addresses issue #1 regarding camera functionality enhancements.

…thod signatures - Removed CameraLensDirection and ResolutionPreset enums from messages.g.h and messages.dart. - Eliminated CameraDescription and MediaSettings classes from messages.dart. - Updated CameraApi methods to reflect changes in camera creation and available cameras retrieval. - Added getTextureId method to CameraApi for retrieving texture ID. - Updated pubspec.yaml to include stream_transform dependency and asset for Pylon setup.

…rchive path

…ies for camera_avfoundation and camera_linux

…ersion 0.2 and remove optional MD5 checksum

…ency ref to camera_0.3 and format code for readability

…vfoundation dependencies to camera_0.5 and modify exposure and focus mode settings to use TrySetValue for better error handling.

…mat in initializeCamera method.

…endencies to camera_0.6

… outputs

… and crop features

…mera sensor orientation

google-cla · 2026-03-11T21:11:38Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request introduces significant enhancements to the camera plugin, including support for lens position control and geometric transformations on iOS, and adds a new Linux implementation. The changes are extensive and well-structured. However, there are several critical issues that need to be addressed, particularly in the new Linux implementation. These include a placeholder LICENSE file, dependencies on a forked repository, a broken widget test, and a couple of critical bugs in the C++ code related to iterator invalidation and incorrect use of a static variable. Addressing these issues is crucial for the stability, security, and maintainability of the plugin.

gemini-code-assist · 2026-03-11T21:17:58Z

packages/camera/camera/example/test/widget_test.dart

+  testWidgets('Counter increments smoke test', (WidgetTester tester) async {
+    // Build our app and trigger a frame.
+    await tester.pumpWidget(const MyApp());
+
+    // Verify that our counter starts at 0.
+    expect(find.text('0'), findsOneWidget);
+    expect(find.text('1'), findsNothing);
+
+    // Tap the '+' icon and trigger a frame.
+    await tester.tap(find.byIcon(Icons.add));
+    await tester.pump();
+
+    // Verify that our counter has incremented.
+    expect(find.text('0'), findsNothing);
+    expect(find.text('1'), findsOneWidget);
+  });


This widget test appears to be the default counter app test created by flutter create. It will fail because the CameraExampleHome widget does not contain a counter or an add button. This test should be updated to test the camera example functionality or be removed.

gemini-code-assist · 2026-03-11T21:17:58Z

packages/camera/camera_linux/LICENSE

@@ -0,0 +1 @@
+TODO: Add your license here.


The LICENSE file is a placeholder. A proper license must be added for this package, consistent with the flutter/packages repository's licensing (e.g., BSD 3-Clause).

gemini-code-assist · 2026-03-11T21:17:58Z

packages/camera/camera_linux/linux/CMakeLists.txt

+set(PYLON_DOWNLOAD_URL "https://github.com/LightX-Innovations/flutter_packages/releases/download/camera_linux_v0.1/pylon-${PYLON_VERSION}_linux-aarch64.tar.gz")
+set(PYLON_ROOT ${CMAKE_BINARY_DIR}/pylon-sdk)
+
+set(PYLON_MPEG_ARCHIVE_NAME "pylon-supplementary-package-for-mpeg-4-1.0.2.121_aarch64.tar.gz")
+set(PYLON_MPEG_ARCHIVE_PATH ${CMAKE_BINARY_DIR}/downloads/${PYLON_MPEG_ARCHIVE_NAME})
+set(PYLON_MPEG_DOWNLOAD_URL "https://github.com/LightX-Innovations/flutter_packages/releases/download/camera_linux_v0.1/pylon-supplementary-package-for-mpeg-4-1.0.2.121_aarch64.tar.gz")


The CMake build script downloads dependencies (pylon-sdk and pylon-supplementary-package-for-mpeg-4) from a fork on GitHub (LightX-Innovations/flutter_packages). This introduces a dependency on a non-official, third-party source which is a security risk and can cause build failures if the fork becomes unavailable. For an official Flutter package, dependencies should be vendored or sourced from official, stable locations.

gemini-code-assist · 2026-03-11T21:17:58Z

packages/camera/camera_linux/linux/camera_host_plugin.cpp

+    for (auto&& camera_it = cameras.begin(); camera_it != cameras.end();
+         ++camera_it) {
+      if (camera_it->camera_id == camera_id) {
+        cameras.erase(camera_it);
+      }
+    }


Erasing an element from a std::vector while iterating over it invalidates the iterator, which can lead to undefined behavior. Since camera IDs are expected to be unique, you should break the loop after erasing the element to prevent issues.

if (camera_it->camera_id == camera_id) { cameras.erase(camera_it); break; }

gemini-code-assist · 2026-03-11T21:17:58Z

packages/camera/camera_linux/linux/camera_video_recorder_image_event_handler.cpp

+    return;
+  }
+
+  static bool isFirstFrame = true;


The isFirstFrame variable is declared as static. This means it will be shared across all instances of CameraVideoRecorderImageEventHandler. If multiple video recordings are started, only the very first frame of the very first recording will trigger the initialization block. This should be a member variable of the class to ensure each recording instance has its own state.

gemini-code-assist · 2026-03-11T21:17:58Z

packages/camera/camera/pubspec.yaml

  camera_platform_interface: ^2.12.0
+  camera_linux:
+    git:
+      url: git@github.com:LightX-Innovations/flutter_packages.git


The camera_linux dependency is pointing to a git@ URL on a personal fork (LightX-Innovations/flutter_packages). This will cause issues for CI and for other developers who do not have SSH access configured for this repository. It's also a dependency on a non-official repository. Please use an https:// URL if this is temporary, and for merging into the main repository, this should point to an official source or be a path dependency if it's part of the same monorepo.

url: https://github.com/LightX-Innovations/flutter_packages.git

gemini-code-assist · 2026-03-11T21:17:59Z

flutter_packages.code-workspace

+    {
+      "path": "./packages/camera/camera_avfoundation"
+    }


There's a duplicate folder entry for ./packages/camera/camera_avfoundation. You can remove one of them to keep the workspace configuration clean.

gemini-code-assist · 2026-03-11T21:17:59Z

packages/camera/camera/example/lib/main.dart

+          Row(
+            children: [
+              ElevatedButton(
+                onPressed: () {
+                  setState(() {
+                    if (TargetPlatform.linux != defaultTargetPlatform) {
+                      return;
+                    }
+                    final CameraLinux nativeCamera =
+                        CameraPlatform.instance as CameraLinux;
+                    nativeCamera.setImageFormatGroup(
+                      controller!.cameraId,
+                      PlatformImageFormatGroup.mono8,
+                    );
+                  });
+                },
+                child: Text('mono8'),
+              ),
+              ElevatedButton(
+                onPressed: () {
+                  setState(() {
+                    if (TargetPlatform.linux != defaultTargetPlatform) {
+                      return;
+                    }
+                    final CameraLinux nativeCamera =
+                        CameraPlatform.instance as CameraLinux;
+                    nativeCamera.setImageFormatGroup(
+                      controller!.cameraId,
+                      PlatformImageFormatGroup.rgb8,
+                    );
+                  });
+                },
+                child: Text('rgb8'),
+              ),
+            ],
+          ),


The platform check for these Linux-specific buttons is inside an unconditional setState call. This is inefficient as it triggers unnecessary rebuilds on all platforms. Since the UI doesn't seem to depend on any state changed here, the setState call is not needed.

A better approach would be to conditionally render this Row only on Linux, or at least disable the buttons on other platforms and remove the setState call.

For example:

if (!kIsWeb && Platform.isLinux) Row( children: <Widget>[ ElevatedButton( onPressed: () { (CameraPlatform.instance as CameraLinux).setImageFormatGroup( controller!.cameraId, PlatformImageFormatGroup.mono8, ); }, child: const Text('mono8'), ), // ... ], )

gemini-code-assist · 2026-03-11T21:17:59Z

packages/camera/camera_linux/CHANGELOG.md

@@ -0,0 +1,3 @@
+## 0.0.1
+
+* TODO: Describe initial release.


The changelog contains a "TODO" message. Please describe the initial release changes.

Depdx and others added 21 commits March 6, 2026 09:45

Remove unnecessary files and update camera_avfoundation package

41c5fcd

Update flutter_packages.code-workspace and FLTCam.m

bc72f28

init linux plugin

325722d

camera plugin linked

7ba6b41

Update CMakeLists.txt to improve Pylon SDK handling and add missing a…

2ce2112

…rchive path

Update pubspec.yaml: Set publish_to to none and specify git dependenc…

b034b7a

…ies for camera_avfoundation and camera_linux

Update pubspec.yaml and CMakeLists.txt: Bump camera dependencies to v…

6ca0593

…ersion 0.2 and remove optional MD5 checksum

Update pubspec.yaml and linux_camera.dart: Change camera_linux depend…

cb0d97e

…ency ref to camera_0.3 and format code for readability

clean upo

99cfd5f

cam mono and rgb

389d80c

camera take picture

d6ebfdd

video recording

766813d

Update pubspec.yaml and camera.cpp: Upgrade camera_linux and camera_a…

92192e6

…vfoundation dependencies to camera_0.5 and modify exposure and focus mode settings to use TrySetValue for better error handling.

Fix image format handling in CameraLinux: Add support for unknown for…

fafa2ec

…mat in initializeCamera method.

Update pubspec.yaml: Upgrade camera_avfoundation and camera_linux dep…

46e85ee

…endencies to camera_0.6

try grab image

370723d

Update iOS deployment target and enhance camera functionality (#1)

e3e4fb8

Add camera transformation support: implement geometric transforms for…

bee5176

… outputs

Add iOS 17+ camera transformation controls: implement rotation, flip,…

a3850a1

… and crop features

Refactor camera rotation handling: adjust rotation degrees for iOS ca…

110a921

…mera sensor orientation

Depdx requested review from LouiseHsu, bparrishMines and hellohuanlin as code owners March 11, 2026 21:11

github-actions bot added p: camera platform-ios platform-linux platform-macos labels Mar 11, 2026

Depdx closed this Mar 11, 2026

gemini-code-assist bot reviewed Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Camera Plugin] Enhance camera functionality and support for transformations#11231

[Camera Plugin] Enhance camera functionality and support for transformations#11231
Depdx wants to merge 21 commits intoflutter:mainfrom
LightX-Innovations:APP-6657-ios-camera-lib-camera-transformation

Depdx commented Mar 11, 2026

Uh oh!

google-cla bot commented Mar 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

gemini-code-assist bot Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Depdx commented Mar 11, 2026

Uh oh!

google-cla bot commented Mar 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant