Skip to content

[pigeon] Use function types in order to avoid dynamic calls #11130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Feb 26, 2026
Merged

[pigeon] Use function types in order to avoid dynamic calls #11130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb08033
[pigeon] Use function types in order to avoid dynamic calls
srawlins Feb 26, 2026
3912c38
Merge branch 'main' into function-type
stuartmorgan-g Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/pigeon/lib/src/generator_tools.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class Indent {
void addScoped(
String? begin,
String? end,
Function func, {
void Function() func, {
bool addTrailingNewline = true,
int nestCount = 1,
}) {
Expand All @@ -132,7 +132,7 @@ class Indent {
void writeScoped(
String? begin,
String? end,
Function func, {
void Function() func, {
int nestCount = 1,
bool addTrailingNewline = true,
}) {
Expand All @@ -148,9 +148,9 @@ class Indent {
/// Scoped increase of the indent level.
///
/// For the execution of [func] the indentation will be incremented by the given amount.
void nest(int count, Function func) {
void nest(int count, void Function() func) {
inc(count);
func(); // ignore: avoid_dynamic_calls
func();
dec(count);
}

Expand Down
Loading