Skip to content

[video_player] : Add video track selection support for Android and iOS - #10688

Merged
auto-submit[bot] merged 171 commits into
flutter:mainfrom
nateshmbhat:feature/video-track-selection-v2
Aug 11, 2026
Merged

[video_player] : Add video track selection support for Android and iOS#10688
auto-submit[bot] merged 171 commits into
flutter:mainfrom
nateshmbhat:feature/video-track-selection-v2

Conversation

@nateshmbhat

@nateshmbhat nateshmbhat commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

This PR adds video track selection (quality switching) support to the video_player plugin for Android and iOS platforms. This allows users to programmatically get available video quality variants and select a specific quality track, similar to the existing audio track selection feature.

Addresses issue : flutter/flutter#58854

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

feat(video_player): add platform check for audio track selection support
@nateshmbhat

Copy link
Copy Markdown
Contributor Author

good to merge this main pr ? @tarrinneal

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

good to merge this main pr ? @tarrinneal

There are two unresolved comments from his review above.

@tarrinneal tarrinneal added the CICD Run CI/CD label Jul 1, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 4, 2026
…lity

Reword getVideoTracks/selectVideoTrack/VideoTrack docs so tracks are not
described solely as quality variants, and drop the 'Returns' lead-in on
isVideoTrackSupportAvailable per review nit.
@nateshmbhat

Copy link
Copy Markdown
Contributor Author

Resolved @stuartmorgan-g @tarrinneal

@stuartmorgan-g
stuartmorgan-g requested review from tarrinneal and removed request for gmackall, reidbaker and stuartmorgan-g July 6, 2026 15:00
@stuartmorgan-g
stuartmorgan-g removed their request for review July 9, 2026 14:30
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Jul 15, 2026
Fixes Linux repo_checks failures:

- pubspec.yaml was still at 2.13.0 while CHANGELOG.md declared 2.14.0,
  failing repository standards validation. Bump to 2.14.0 to match.
- Reformat an expect() in video_player_test.dart per the Dart version
  used by repo_checks. This also fixes the publishability check, which
  failed only because the format step left the tree dirty.
- Strip trailing whitespace from the new CHANGELOG entry.
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 31, 2026
@nateshmbhat

nateshmbhat commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@stuartmorgan-g can you pls review and add cicd label ?

we're good to merge this PR

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

I'm not a reviewer for this PR. In the future, please reach out to a reviewer for help getting a PR landed once it's been reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD federated: all_changes PR that contains changes for all packages for a federated plugin change p: video_player

Projects

None yet

Development

Successfully merging this pull request may close these issues.