-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[pigeon] Fix kotlin warning about calling bridge method #10632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c5a0497
Modify genrated code to implement methods from *PigeonEventChannelWra…
reidbaker 8434383
Bump tooling/yaml version, update changelog
reidbaker e29d755
update kotlin generated tests
reidbaker ded0ac9
Implements should be outside companion object
reidbaker 3bde0ba
Update packages/pigeon/CHANGELOG.md
reidbaker 840ed28
Make implementation abstract to force implementation while still not …
reidbaker 5abaa3b
Remove open and implemenation
reidbaker a8b0df1
Modify example to implement cancel
reidbaker 5b75a9e
Add onCancel method to TestPlugin.kt
reidbaker b171079
Update example readme
reidbaker 5e98a5b
Merge branch 'main' into i_178908_bridge_call
reidbaker c405fa3
Remove open with abstract because it causes lint errors
reidbaker b1e4279
onListen and onCancel have implementations so that not every extensio…
reidbaker 0903bf6
Update generated files
reidbaker cd16ddf
Remove abstract and modify changelog
reidbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.