Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/pigeon/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 26.1.5

* [kotlin] Fixes "bridge method" warning that occures when a uses *PigeonEventChannelWrapper as a
supertype without implementing all methods.
Comment thread
reidbaker marked this conversation as resolved.
Outdated

## 26.1.4

* [swift][kotlin] Fixes crash that occurs when an object that is removed from the instance manager
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,5 +185,9 @@ abstract class StreamEventsStreamHandler :
EventChannel(messenger, channelName, EventChannelMessagesPigeonMethodCodec)
.setStreamHandler(internalStreamHandler)
}
// Implement methods from EventChannelMessagesPigeonEventChannelWrapper
override open fun onListen(p0: Any?, sink: PigeonEventSink<PlatformEvent>) {}

override open fun onCancel(p0: Any?) {}
}
}
2 changes: 1 addition & 1 deletion packages/pigeon/lib/src/generator_tools.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import 'generator.dart';
/// The current version of pigeon.
///
/// This must match the version in pubspec.yaml.
const String pigeonVersion = '26.1.4';
const String pigeonVersion = '26.1.5';

/// Read all the content from [stdin] to a String.
String readStdin() {
Expand Down
6 changes: 6 additions & 0 deletions packages/pigeon/lib/src/kotlin/kotlin_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,12 @@ if (wrapped == null) {
val internalStreamHandler = ${generatorOptions.fileSpecificClassNameComponent}PigeonStreamHandler<${_kotlinTypeForDartType(func.returnType)}>(streamHandler)
EventChannel(messenger, channelName, ${generatorOptions.fileSpecificClassNameComponent}$_pigeonMethodChannelCodec).setStreamHandler(internalStreamHandler)
}
// Implement methods from ${generatorOptions.fileSpecificClassNameComponent}PigeonEventChannelWrapper
override
open fun onListen(p0: Any?, sink: PigeonEventSink<${_kotlinTypeForDartType(func.returnType)}>) {}

override
open fun onCancel(p0: Any?) {}
}
Comment thread
tarrinneal marked this conversation as resolved.
Outdated
}
''');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,10 @@ abstract class StreamIntsStreamHandler : EventChannelTestsPigeonEventChannelWrap
EventChannel(messenger, channelName, EventChannelTestsPigeonMethodCodec)
.setStreamHandler(internalStreamHandler)
}
// Implement methods from EventChannelTestsPigeonEventChannelWrapper
override open fun onListen(p0: Any?, sink: PigeonEventSink<Long>) {}

override open fun onCancel(p0: Any?) {}
}
}

Expand All @@ -594,6 +598,10 @@ abstract class StreamEventsStreamHandler :
EventChannel(messenger, channelName, EventChannelTestsPigeonMethodCodec)
.setStreamHandler(internalStreamHandler)
}
// Implement methods from EventChannelTestsPigeonEventChannelWrapper
override open fun onListen(p0: Any?, sink: PigeonEventSink<PlatformEvent>) {}

override open fun onCancel(p0: Any?) {}
}
}

Expand All @@ -614,5 +622,9 @@ abstract class StreamConsistentNumbersStreamHandler :
EventChannel(messenger, channelName, EventChannelTestsPigeonMethodCodec)
.setStreamHandler(internalStreamHandler)
}
// Implement methods from EventChannelTestsPigeonEventChannelWrapper
override open fun onListen(p0: Any?, sink: PigeonEventSink<Long>) {}

override open fun onCancel(p0: Any?) {}
}
}
2 changes: 1 addition & 1 deletion packages/pigeon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
version: 26.1.4 # This must match the version in lib/src/generator_tools.dart
version: 26.1.5 # This must match the version in lib/src/generator_tools.dart

environment:
sdk: ^3.9.0
Expand Down