Skip to content

[web_benchmarks] Report correct expected metrics for wasm #10236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Nov 14, 2025
Merged

[web_benchmarks] Report correct expected metrics for wasm #10236

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f7d2c6
[web_benchmarks] Report correct expected metrics for wasm
mdebbar Oct 15, 2025
65cb112
CHANGELOG
mdebbar Oct 15, 2025
0ac502c
Merge branch 'main' into use_wasm_frames
mdebbar Oct 23, 2025
2c09aee
fix versions
mdebbar Oct 23, 2025
49edf48
Merge branch 'main' into use_wasm_frames
stuartmorgan-g Nov 12, 2025
ab28d36
Merge branch 'main' into use_wasm_frames
stuartmorgan-g Nov 13, 2025
14b9ff7
format
mdebbar Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/web_benchmarks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## NEXT
## 4.1.0

* Fixes the reported metrics in `expectedBenchmarkMetrics` for wasm.
* Updates minimum supported SDK version to Flutter 3.38/Dart 3.7.
* Updates minimum supported SDK version to Flutter 3.29/Dart 3.7.

## 4.0.0
Expand Down
15 changes: 8 additions & 7 deletions packages/web_benchmarks/lib/src/metrics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,15 @@ final class PercentileMetricComputation extends BenchmarkMetricComputation {

/// The list of expected benchmark metrics for the current compilation mode, as
/// determined by the value of [useWasm].
List<BenchmarkMetric> expectedBenchmarkMetrics({required bool useWasm}) {
List<BenchmarkMetric> expectedBenchmarkMetrics({
@Deprecated(
'This parameter is unused and will be removed in a future release.',
)
bool? useWasm,
}) {
return <BenchmarkMetric>[
// The skwasm renderer doesn't have preroll or apply frame steps in its
// rendering.
if (!useWasm) ...<BenchmarkMetric>[
BenchmarkMetric.prerollFrame,
BenchmarkMetric.applyFrame,
],
BenchmarkMetric.prerollFrame,
BenchmarkMetric.applyFrame,
BenchmarkMetric.drawFrame,
BenchmarkMetric.flutterFrameTotalTime,
BenchmarkMetric.flutterFrameBuildTime,
Expand Down
4 changes: 2 additions & 2 deletions packages/web_benchmarks/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ name: web_benchmarks
description: A benchmark harness for performance-testing Flutter apps in Chrome.
repository: https://github.com/flutter/packages/tree/main/packages/web_benchmarks
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22
version: 4.0.0
version: 4.1.0

environment:
sdk: ^3.7.0
flutter: ">=3.29.0"
flutter: ">=3.38.0"

dependencies:
collection: ^1.18.0
Expand Down
6 changes: 3 additions & 3 deletions packages/web_benchmarks/testing/test_app/benchmark/web_benchmarks_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ Future<BenchmarkResults> _runBenchmarks({
);

final List<String> expectedMetrics =
expectedBenchmarkMetrics(
useWasm: compilationOptions.useWasm,
).map((BenchmarkMetric metric) => metric.label).toList();
expectedBenchmarkMetrics()
.map((BenchmarkMetric metric) => metric.label)
.toList();

for (final String benchmarkName in benchmarkNames) {
for (final String metricName in expectedMetrics) {
Expand Down