Skip to content

[file_selector] updates build files to use JVM 17 #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 24 commits into from
Sep 30, 2025
Merged

[file_selector] updates build files to use JVM 17 #10097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e93c97b
java 17
AbdeMohlbi Sep 27, 2025
cb2949f
Update version in pubspec.yaml
AbdeMohlbi Sep 27, 2025
4992716
Merge branch 'main' into file_selector_java_17
AbdeMohlbi Sep 28, 2025
2fe5d80
Use "minor" version
reidbaker Sep 29, 2025
567651c
Changelog cant start with +0
reidbaker Sep 29, 2025
d07891f
Update pubspec.yaml to set min flutter to 3.35.0
reidbaker Sep 29, 2025
e3c986d
add new min constraints to CHANGELOG
AbdeMohlbi Sep 29, 2025
13b5663
Update pubspec.yaml
AbdeMohlbi Sep 29, 2025
b3d14d3
Update CHANGELOG.md to respect the new constraints
AbdeMohlbi Sep 29, 2025
5caba7c
Formatter
reidbaker Sep 29, 2025
fb7d61d
Regenerate file then format them
reidbaker Sep 29, 2025
8b82009
Update pubspec.yaml
reidbaker Sep 29, 2025
bd9fa38
Undo pidgon change
reidbaker Sep 29, 2025
032bc19
Update packages/file_selector/file_selector/pubspec.yaml
reidbaker Sep 29, 2025
d23429e
Merge branch 'main' into file_selector_java_17
AbdeMohlbi Sep 29, 2025
12c07f7
Update CHANGELOG.md
AbdeMohlbi Sep 29, 2025
6a48c2b
Update pubspec.yaml
AbdeMohlbi Sep 29, 2025
2df264f
Update pubspec.yaml
AbdeMohlbi Sep 29, 2025
98fbf30
format
reidbaker Sep 29, 2025
6ed7020
Update file_selector_api.g.dart
AbdeMohlbi Sep 29, 2025
d6040e4
Update GeneratedFileSelectorApi.java
AbdeMohlbi Sep 29, 2025
70fcd54
Merge branch 'main' into file_selector_java_17
AbdeMohlbi Sep 29, 2025
4bee17a
use carat syntax when defining dart versions
reidbaker Sep 29, 2025
9476147
Merge branch 'main' into file_selector_java_17
AbdeMohlbi Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/file_selector/file_selector/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ android {
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'
}

sourceSets {
Expand Down
5 changes: 5 additions & 0 deletions packages/file_selector/file_selector_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.5.2

* Updates Java compatibility version to 17.
* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.

## 0.5.1+17

* Updates Pigeon to 26.x.
Expand Down
4 changes: 2 additions & 2 deletions packages/file_selector/file_selector_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ android {
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

defaultConfig {
Expand Down
4 changes: 2 additions & 2 deletions packages/file_selector/file_selector_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ android {
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

defaultConfig {
Expand Down
5 changes: 3 additions & 2 deletions packages/file_selector/file_selector_android/lib/src/file_selector_api.g.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,9 @@ class FileSelectorApi {
BinaryMessenger? binaryMessenger,
String messageChannelSuffix = '',
}) : pigeonVar_binaryMessenger = binaryMessenger,
pigeonVar_messageChannelSuffix =
messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
pigeonVar_messageChannelSuffix = messageChannelSuffix.isNotEmpty
? '.$messageChannelSuffix'
: '';
final BinaryMessenger? pigeonVar_binaryMessenger;

static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();
Expand Down
6 changes: 3 additions & 3 deletions packages/file_selector/file_selector_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ name: file_selector_android
description: Android implementation of the file_selector package.
repository: https://github.com/flutter/packages/tree/main/packages/file_selector/file_selector_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
version: 0.5.1+17
version: 0.5.2

environment:
sdk: ^3.7.0
flutter: ">=3.29.0"
sdk: ^3.9.0
flutter: ">=3.35.0"

flutter:
plugin:
Expand Down