Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump flutter_svg from 2.0.3 to 2.0.5 in /flutter_news_example/packages/app_ui #848

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 10, 2023

Bumps flutter_svg from 2.0.3 to 2.0.5.

Changelog

Sourced from flutter_svg's changelog.

2.0.5

  • Allow malformed UTF-8 in loaders.
  • Make the cache respect the SvgTheme and ColorMapper, if present.

2.0.4

  • Newer version of vector_graphics.
  • Caching bug fix.
  • Reintroduce clipBehavior.
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dart Pull requests that update Dart code dependencies Pull requests that update a dependency file labels Apr 10, 2023
Bumps [flutter_svg](https://github.com/dnfield/flutter_svg) from 2.0.3 to 2.0.5.
- [Release notes](https://github.com/dnfield/flutter_svg/releases)
- [Changelog](https://github.com/dnfield/flutter_svg/blob/master/CHANGELOG.md)
- [Commits](dnfield/flutter_svg@v2.0.3...v2.0.5)

---
updated-dependencies:
- dependency-name: flutter_svg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pub/flutter_news_example/packages/app_ui/flutter_svg-2.0.5 branch from 03b59ca to 4ae4f36 Compare April 11, 2023 14:57
@valentinallavayol
Copy link
Contributor

Hey @marwfair !

After doing a research we are unable to upgrade flutter_svg due to some issues with flutter_gen.

You can check the issue on the flutter_gen repo.

This was addressed on this pr #827 when dependabot bumped the dependency to 2.0.4, and it wasn't fixed then, and it seems it still not fixed now.

I believe it would be good to hold this update until flutter_gen fixes that issue. What do you think?

@valentinallavayol
Copy link
Contributor

Hey @marwfair ! So, previously we were closing flutter_svg dependency bumps since they were having an issue with flutter_gen regarding ClipBehavior . It was fixed and the issue was closed, so I updated all generated assets on the toolkit and its running just fine, so I'd say this is now ready to be merged in!

@scarletteliza scarletteliza merged commit 6da7f74 into main May 15, 2023
@scarletteliza scarletteliza deleted the dependabot/pub/flutter_news_example/packages/app_ui/flutter_svg-2.0.5 branch May 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants