Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump formz from 0.5.0+1 to 0.6.0 in /flutter_news_example/packages/form_inputs #834

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 24, 2023

Bumps formz from 0.5.0+1 to 0.6.0.

Release notes

Sourced from formz's releases.

v0.6.0

  • feat: add FormzInputErrorCacheMixin mixin
  • feat: add isInProgressOrSuccess to FormzSubmissionStatusX
  • feat: add purity check to FormzMixin
Changelog

Sourced from formz's changelog.

0.6.0

  • feat: add FormzInputErrorCacheMixin mixin
  • feat: add isInProgressOrSuccess to FormzSubmissionStatusX
  • feat: add purity check to FormzMixin

0.5.0

  • docs: add caching example
  • refactor: update very good analysis, workflows, flutter/dart version
  • feat: update very good analysis
  • feat: add dependabot
  • BREAKING: this release promotes 0.5.0-dev.1 which brings breaking changes

0.5.0-dev.1

  • docs: use nullable validator in README

  • feat: add example Flutter app

  • BREAKING: decouple purity, validity, and submission status

    Changes

    1. FormzStatus renamed to FormzSubmissionStatus:
    /// Enum representing the submission status of a form.
    enum FormzSubmissionStatus {
    /// The form is in the process of being submitted.
    inProgress,
    /// The form has been submitted successfully.
    success,
    /// The form submission failed.
    failure,
    /// The form submission has been canceled.
    canceled
    }

    1. FormzInput class no longer exposes a status (FormzInputStatus). Instead there are isValid and isNotValid getters:
    class NameInput extends FormzInput<String, NameInputError> {
    const NameInput.pure() : super.pure('');
    const NameInput.dirty({String value = ''}) : super.dirty(value);
    @​override
    NameInputError? validator(String value) {

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dart Pull requests that update Dart code dependencies Pull requests that update a dependency file labels Mar 24, 2023
@dependabot dependabot bot requested a review from scarletteliza as a code owner March 24, 2023 17:06
@dependabot dependabot bot force-pushed the dependabot/pub/flutter_news_example/packages/form_inputs/formz-0.6.0 branch 5 times, most recently from 467166e to 66f0b7d Compare March 30, 2023 21:28
Bumps [formz](https://github.com/VeryGoodOpenSource/formz) from 0.5.0+1 to 0.6.0.
- [Release notes](https://github.com/VeryGoodOpenSource/formz/releases)
- [Changelog](https://github.com/VeryGoodOpenSource/formz/blob/main/CHANGELOG.md)
- [Commits](VeryGoodOpenSource/formz@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: formz
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pub/flutter_news_example/packages/form_inputs/formz-0.6.0 branch from 66f0b7d to f1e2d54 Compare March 30, 2023 21:45
@valentinallavayol
Copy link
Contributor

Hey @marwfair ! Checked this dependency bump and it seems to be no issues when running the app, and no breaking changes.

When I changed to this branch and ran flutter clean to run the app, I did find some dependency error that is not related to this. When I tried to pod install it output an error with the FBSDKLoginKit pod that comes from the flutter_facebook_auth dependency.

Apparently the dependency bump from flutter_facebook_auth we merged last week required an update on the platform of the podfile to platform :ios, '12.0', currently its on iOS 11. I must have checked it without running flutter clean so I didn't come across that error. 😞

I wanted to ask what was the best approach here, if we should update the minimum platform to be 12, or we should downgrade the flutter_facebook_auth so we could continue supporting iOS 11 as min platform. I'll upload a new PR with the fix.

@kaiceyd
Copy link
Contributor

kaiceyd commented Apr 11, 2023

@zoeyfan @timothyhoang-google -- is it required that we support iOS 11 in this toolkit or is it okay to update to iOS 12?

iOS 11 was released over 5 years ago, so it's probably time to update to avoid more issues like this in the future, but hoping to confirm with you both before we move forward.

Thank you!

@zoeyfan
Copy link

zoeyfan commented Apr 11, 2023

Updating to iOS 12 sounds reasonable to me!

kaiceyd
kaiceyd previously approved these changes May 9, 2023
…t does not take latest flutter version before updating repository
@tomarra tomarra merged commit 717545d into main May 11, 2023
@tomarra tomarra deleted the dependabot/pub/flutter_news_example/packages/form_inputs/formz-0.6.0 branch May 11, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants