Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump video_player_platform_interface from 5.1.4 to 6.0.1 in /flutter_news_example/packages/news_blocks_ui #671

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 5, 2023

Bumps video_player_platform_interface from 5.1.4 to 6.0.1.

Commits
  • f31a438 [video_player] Fix file URI construction (#6803)
  • 9990a4b [ci] Improve analysis_options alignment with flutter/packages (#6728)
  • 897ec59 [ci] Removes unnecessary overrides. (#6669)
  • 38c9324 [video_player]add integration test for inverted aspect ratio bug (#6662)
  • 91122ec Update Gradle and AGP in examples to 7.0 (#6625)
  • 1459767 [various] Remove unused Gradle files (#6623)
  • 42f55ed [various] Update Gradle in examples (#6614)
  • b175843 [various] Add some more Java lint ignores (#6562)
  • 25e10b2 [video_player] Fixes a bug where the aspect ratio of some HLS videos are inco...
  • 9428081 Enable no_leading_underscores_for_local_identifiers (#6509)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dart Pull requests that update Dart code dependencies Pull requests that update a dependency file labels Jan 5, 2023
@dependabot dependabot bot force-pushed the dependabot/pub/flutter_news_example/packages/news_blocks_ui/video_player_platform_interface-6.0.1 branch 3 times, most recently from 8f96c8f to 3180d64 Compare January 10, 2023 02:38
@domesticmouse
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@domesticmouse
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pub/flutter_news_example/packages/news_blocks_ui/video_player_platform_interface-6.0.1 branch 6 times, most recently from 1ac092a to 9d5c3d2 Compare January 20, 2023 02:52
Bumps [video_player_platform_interface](https://github.com/flutter/plugins/tree/main/packages/video_player) from 5.1.4 to 6.0.1.
- [Release notes](https://github.com/flutter/plugins/releases)
- [Commits](https://github.com/flutter/plugins/commits/video_player_platform_interface-v6.0.1/packages/video_player)

---
updated-dependencies:
- dependency-name: video_player_platform_interface
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pub/flutter_news_example/packages/news_blocks_ui/video_player_platform_interface-6.0.1 branch from 9d5c3d2 to b59e174 Compare January 20, 2023 21:00
@matiasleyba
Copy link
Contributor

@domesticmouse @felangel I have worked on this PR in other toolkit implementation, so I have the tests fixed and I can collaborate right here, can we push commits on this PR o do we have to create a new one?

@felangel
Copy link
Contributor

@domesticmouse @felangel I have worked on this PR in other toolkit implementation, so I have the tests fixed and I can collaborate right here, can we push commits on this PR o do we have to create a new one?

That’s awesome, I think it should be fine to push to this branch if you’d like.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 24, 2023

A newer version of video_player_platform_interface exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

…/news_blocks_ui/video_player_platform_interface-6.0.1
@matiasleyba
Copy link
Contributor

Hi @felangel @marwfair 👋🏻
I have updated this PR by adding FakeVideoPlayerPlatform class and setting up VideoPlayerPlatform.instance on tests that are using VideoPlayer library in order to fix test issues.

In my opinion is ready to merge.

Copy link

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kaiceyd added 2 commits March 30, 2023 11:28
…/news_blocks_ui/video_player_platform_interface-6.0.1
…/news_blocks_ui/video_player_platform_interface-6.0.1
@kaiceyd kaiceyd merged commit bb474ff into main Mar 30, 2023
@kaiceyd kaiceyd deleted the dependabot/pub/flutter_news_example/packages/news_blocks_ui/video_player_platform_interface-6.0.1 branch March 30, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants