Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds delete account functionality to template #1152

Merged
merged 16 commits into from
Mar 25, 2024

Conversation

elianortega
Copy link
Contributor

Description

  • delete account has become a requirement in most reviews by Apple, so it would be great if it's added by default to the template.

Screenshots

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Contributor

@matiasleyba matiasleyba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments to review.

@elianortega elianortega requested a review from matiasleyba March 21, 2024 21:01
Copy link
Contributor

@matiasleyba matiasleyba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to review before merge

@elianortega elianortega requested a review from matiasleyba March 22, 2024 16:46
Copy link
Contributor

@matiasleyba matiasleyba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

matiasleyba
matiasleyba previously approved these changes Mar 22, 2024
@matiasleyba
Copy link
Contributor

@elianortega I'm not being able to merge the PR, would you mind checking your fork repo to fix the issues there to see if after fixing the issues there we can merge it here, thanks in advance!

@elianortega
Copy link
Contributor Author

@matiasleyba I just checked the PR on my repository and it is failing on the api.yaml workflow on the coverage job because of files that were not even modified on this PR. This is the job.

I'll check it out but I'm a bit more inclined to solve that on another PR, what do you think?

@matiasleyba
Copy link
Contributor

@elianortega I agree, let's solve them in another PR.

@matiasleyba matiasleyba merged commit a0d44ee into flutter:main Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants