-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds delete account functionality to template #1152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comments to review.
flutter_news_example/lib/user_profile/view/user_profile_page.dart
Outdated
Show resolved
Hide resolved
flutter_news_example/lib/user_profile/view/user_profile_page.dart
Outdated
Show resolved
Hide resolved
flutter_news_example/lib/user_profile/widgets/user_profile_delete_account_dialog.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment to review before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@elianortega I'm not being able to merge the PR, would you mind checking your fork repo to fix the issues there to see if after fixing the issues there we can merge it here, thanks in advance! |
@matiasleyba I just checked the PR on my repository and it is failing on the I'll check it out but I'm a bit more inclined to solve that on another PR, what do you think? |
@elianortega I agree, let's solve them in another PR. |
Description
Screenshots
Type of Change