Remove deprecated CupertinoDialog #73604
Conversation
Piinks
added
framework
flutter-dashboard
bot
added
the
f: cupertino
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@goderbauer I know we can't test the fix, but we're going to be removing the deprecation anyways, what do you think about including the fix support? |
packages/flutter/lib/fix_data.yaml
Outdated
| @@ -11,6 +11,33 @@ | |||
| version: 1 | |||
| transforms: | |||
|
|
|||
| # Change made in https://github.com/flutter/flutter/pull/20649 | |||
| # TODO(Piinks): Add tests when `bulkApply:false` testing is supported. | |||
There was a problem hiding this comment.
Is there an issue on "dart fix" to add testing support for this that we can link from here?
There was a problem hiding this comment.
And do we know what the timeline for adding that support is?
There was a problem hiding this comment.
Filed dart-lang/sdk#44639
|
Confirmed the google test failures here were unrelated and everything passes. Manually set to green. |
Description
This removes the deprecated
CupertinoDialogwidget that has reached the EOL . TheCupertinoPopupSurfaceorCupertinoAlertDialogshould be used instead.Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime
More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad
Related Issues
Deprecated in #20649
#73910
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.