enable lint use_full_hex_values_for_flutter_colors #35056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Jun 25, 2019
| TextSpan( | ||
| text: 'inner', | ||
| style: TextStyle(color: Color(0xff402f4ff)), | ||
| style: TextStyle(color: Color(0xf402f4ff)), |
Contributor
There was a problem hiding this comment.
Does this pass?
I suspect the intention here was to have full alpha and drop that last f, but hard to say.
Contributor
Author
There was a problem hiding this comment.
Yes, it passes locally. I didn't really know what was expected but as 0xff402f4ff is treated as 32 bits integer it's logically truncated on left.
dnfield
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables lint use_full_hex_values_for_flutter_colors
Related Issues
None
Tests
None
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?