Test reporter #28297
Test reporter #28297
Conversation
dnfield
added
a: tests
dnfield
force-pushed
the
test_reporter
branch
from
dd3f754 to
16bb5a7
Compare
|
This is working on Cirrus, need to check into how I can make it work for LUCI. |
|
This is still TODO on LUCI but would be an improvement for Cirrus. Marking ready for review. /cc @goderbauer |
|
This doesn't appear to be working properly: https://cirrus-ci.com/task/4970475997364224 |
|
Something's messed up on Windows. Checking. |
|
That will be fixed by #28970 |
| } | ||
|
|
||
| Future<bq.BigqueryApi> _getBigqueryApi() async { | ||
| // TODO(dnfield): How will we do this on LUCI? |
There was a problem hiding this comment.
| if (privateKey == null || privateKey.isEmpty) { | ||
| return null; | ||
| } | ||
| final auth.ServiceAccountCredentials accountCredentials = auth.ServiceAccountCredentials( //.fromJson(credentials); |
There was a problem hiding this comment.
nit: stray comment on this line?
|
What's the background here? |
|
The compact formatter makes it really hard to find what tests actually failed - particularly since Cirrus only shows us the tail of the log (which almost never contains the test that failed). I also would like to see all of our test results in a database so we could find failing tests rather than checking failing bots. This is currently turned off though, as it had a couple problems I haven't been able to fully sort through yet. |
5 participants
This PR wraps all test output so that errors are printed last. It also sends all test result data to a bigquery table we can look at to get better info about what tests failed and when without needing to visit specific builder pages.
It's only implemented for Cirrus at the moment. It should be possible to implement for LUCI as well, but I'd rather tackle that separately.