Skip to content

Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Oct 21, 2025
Merged

Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bef040
Make sure that a BottomSheet doesn't crash in 0x0 environment
ahmedsameha1 Jul 16, 2025
8238600
Use Size.zero instead of Size.isEmpty() in the zero area test
ahmedsameha1 Jul 24, 2025
4e28e52
isEmpty
dkwingsmt Aug 13, 2025
26d6026
Using Size.zero instead of isEmpty
ahmedsameha1 Sep 22, 2025
82e6fe8
Merge branch 'master' into handle#6537-BottomSheet
victorsanni Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/flutter/test/material/bottom_sheet_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2889,6 +2889,24 @@ void main() {
expect(FocusScope.of(tester.element(find.text('BottomSheet'))).hasFocus, false);
expect(focusNode.hasFocus, true);
});

testWidgets('BottomSheet does not crash at zero area', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: SizedBox.shrink(
child: BottomSheet(
onClosing: () {},
builder: (BuildContext context) => const Text('X'),
),
),
),
),
),
);
expect(tester.getSize(find.byType(BottomSheet)), Size.zero);
});
}

class _TestPage extends StatelessWidget {
Expand Down