-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update Google testing docs #167685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google testing docs #167685
Conversation
|
|
||
| Googlers can go to http://frob and override the results. | ||
|
|
||
| ## Where can I get help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanlurey Does this sound right to you? The team-google-testing does not exist anymore, but I didn't want to assume that maps to team-infra now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah team-infra is fine, though for scalability reasons contributions being reviewed by Googlers (which I suspect anything with a failed Google Testing check will need to be) probably should go through the reviewer before someone files a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok good call, yeah this whole proposal around the queue is to create better expectation and transparency around that bottleneck when folks run into Google testing. Only so may Googlers. :)
I will add an explicit call out here to work with the assigned reviewer before filing an infra ticket.
matanlurey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM changes around team-g3 -> team-infra.
|
@Piinks Are you ready to submit this (once the tree goes green)? There are additional changes I'd like to make (as part of go/flutter-google3-roll-policy), but I want to do it after this PR lands so we don't cause merge conflicts for each other. |
|
Sure SGTM! Thanks so much for the consideration. |
|
Hello! This PR is the unfortunate target of a never-delivered pubsub message and thus was stuck in the queue. I removed it to kick the queue and I'm adding it back to the queue. No work needed from you. |
📜 [Doc on the Google testing Queue](https://docs.google.com/document/d/15gMCfOIUWlsRuLRMhMge-7odVHTzU8zibiVFDLdn3Pk/edit?usp=sharing) Project for tracking: https://github.com/orgs/flutter/projects/200 This updates the docs on Google testing and incorporates the proposed queue for managing blocked PRs better. Fixes flutter#162832 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
📜 Doc on the Google testing Queue
Project for tracking: Google Testing Queue
This updates the docs on Google testing and incorporates the proposed queue for managing blocked PRs better.
Fixes #162832
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.