Skip to content

[Impeller] disable GLES tracing unless opted in. #165887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Mar 26, 2025
Merged

[Impeller] disable GLES tracing unless opted in. #165887

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b91f7f6
[Impeller] disable GLES tracing unless opted in.
Mar 25, 2025
f294997
aaron review.
Mar 25, 2025
6f6e82c
++
Mar 25, 2025
1632fc5
++
Mar 25, 2025
cf994d3
add back test with raw ptr.
Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/src/flutter/impeller/renderer/backend/gles/proc_table_gles.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ ProcTableGLES::ProcTableGLES( // NOLINT(google-readability-function-size)

#undef IMPELLER_PROC

if (!description_->HasDebugExtension()) {
if (!description_->HasDebugExtension() || !ENABLE_GLES_LABELING) {
Copy link
Member

@gaaclarke gaaclarke Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!description_->HasDebugExtension() || !ENABLE_GLES_LABELING) {
if (!ENABLE_GLES_LABELING || !description_->HasDebugExtension()) {

You want to hit the macro first.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

PushDebugGroupKHR.Reset();
PopDebugGroupKHR.Reset();
ObjectLabelKHR.Reset();
Expand Down
3 changes: 3 additions & 0 deletions engine/src/flutter/impeller/renderer/backend/gles/proc_table_gles.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
#include "impeller/renderer/backend/gles/description_gles.h"
#include "impeller/renderer/backend/gles/gles.h"

/// Enable to allow GLES to push/pop labels for usage in GPU traces
#define ENABLE_GLES_LABELING false
Copy link
Member

@gaaclarke gaaclarke Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a prefix IMP_ or FLT_

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


namespace impeller {

const char* GLErrorToString(GLenum value);
Expand Down