Skip to content

Fix korean cupertino datepicker datetime order #163850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Feb 27, 2025
Merged

Fix korean cupertino datepicker datetime order #163850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35a8178
Fix korean cupertino datepicker datetime order
chul0061 Feb 21, 2025
eccbc25
Added Jin jeongsu to authors
chul0061 Feb 21, 2025
dbd29a9
Merge branch 'master' into master
chul0061 Feb 21, 2025
876798b
Add test for korean cupertino datepicker datetime order fix
chul0061 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,4 @@ dy0gu <[email protected]>
Albert Wolszon <[email protected]>
Mohammed Chahboun <[email protected]>
Abdessalem Mohellebi <[email protected]>
Jin Jeongsu <[email protected]>
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/cupertino_ko.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"datePickerMinuteSemanticsLabelOne": "1분",
"datePickerMinuteSemanticsLabelOther": "$minute분",
"datePickerDateOrder": "ymd",
"datePickerDateTimeOrder": "date_time_dayPeriod",
"datePickerDateTimeOrder": "date_dayPeriod_time",
"anteMeridiemAbbreviation": "오전",
"postMeridiemAbbreviation": "오후",
"todayLabel": "오늘",
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7936,7 +7936,7 @@ class CupertinoLocalizationKo extends GlobalCupertinoLocalizations {
String get datePickerDateOrderString => 'ymd';

@override
String get datePickerDateTimeOrderString => 'date_time_dayPeriod';
String get datePickerDateTimeOrderString => 'date_dayPeriod_time';

@override
String? get datePickerHourSemanticsLabelFew => null;
Expand Down
14 changes: 14 additions & 0 deletions packages/flutter_localizations/test/cupertino/translations_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,20 @@ void main() {
expect(localizations.datePickerDayOfMonth(1), '1日');
expect(localizations.datePickerDayOfMonth(1, 2), '周二 1日');
});

testWidgets('Test correct time order for CupertinoDatePicker in Korean locale', (
WidgetTester tester,
) async {
const Locale locale = Locale('ko');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);

final CupertinoLocalizations localizations = await GlobalCupertinoLocalizations.delegate.load(
locale,
);

expect(localizations, isA<CupertinoLocalizationKo>());
expect(localizations.datePickerDateTimeOrder, DatePickerDateTimeOrder.date_dayPeriod_time);
});
}

class _FakeEditableText extends EditableText {
Expand Down