Skip to content

CircularProgressIndicator throws null exception #163356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Feb 20, 2025
Merged

CircularProgressIndicator throws null exception #163356

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a41b384
Fix Null check operator used on a null value
dbspoudel Feb 14, 2025
e107af8
Add test for legacy CircularProgressIndicator with custom track color…
dbspoudel Feb 17, 2025
28dc39b
Merge branch 'master' into fix163253
dbspoudel Feb 18, 2025
637f5b7
Fix test code
dbspoudel Feb 18, 2025
7a54764
review changes: improve test name & check for exception
dbspoudel Feb 18, 2025
bd6caab
format file
dbspoudel Feb 18, 2025
80551c5
Merge branch 'master' into fix163253
dbspoudel Feb 18, 2025
c246085
remove semantics matches from test
dbspoudel Feb 18, 2025
26be47a
Merge branch 'master' into fix163253
dbspoudel Feb 18, 2025
0fe753b
Merge branch 'master' into fix163253
dbspoudel Feb 19, 2025
2a5e601
Merge branch 'master' into fix163253
dbspoudel Feb 19, 2025
2570b6b
Merge branch 'master' into fix163253
dbspoudel Feb 20, 2025
5d95ea1
kick tests
dbspoudel Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutter/lib/src/material/progress_indicator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ class _CircularProgressIndicatorPainter extends CustomPainter {
..strokeCap = strokeCap ?? StrokeCap.round
..style = PaintingStyle.stroke;
// If hasGap is true, draw the background arc with a gap.
if (hasGap && value! > _epsilon) {
if (hasGap && value != null && value! > _epsilon) {
final double arcRadius = arcActualSize.shortestSide / 2;
final double strokeRadius = strokeWidth / arcRadius;
final double gapRadius = trackGap! / arcRadius;
Expand Down