Skip to content

Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList #124459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 12, 2023
Merged

Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList #124459

auto-submit merged 2 commits into from
Apr 12, 2023

Conversation

@gabrielgarciagava
Copy link
Contributor

@gabrielgarciagava gabrielgarciagava commented Apr 8, 2023 •
edited by Piinks
Loading

Fixes #120479

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Apr 8, 2023
gabrielgarciagava
gabrielgarciagava commented Apr 8, 2023
View reviewed changes
packages/flutter/test/widgets/reorderable_list_test.dart Outdated
Copy link
Contributor Author

@gabrielgarciagava gabrielgarciagava Apr 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the auto scroll happens dispatching animateTo one after the other, I could not find any other way to let them execute apart from pumping with some frequency.

  • pumpAndSettle does not work because it never settles, it would only settle when the list got to the end, which I don't wan't.
  • pump (even with a big duration) does not work because it won't let all the animateTo to happen, just the first one

Please let me know if there is a better way to achieve this.

@Piinks Piinks self-requested a review April 10, 2023 19:35
Piinks
Piinks reviewed Apr 10, 2023
View reviewed changes
Piinks
Piinks reviewed Apr 10, 2023
View reviewed changes
Piinks
Piinks reviewed Apr 10, 2023
View reviewed changes
@chunhtai chunhtai self-requested a review April 10, 2023 20:54
chunhtai
chunhtai reviewed Apr 10, 2023
View reviewed changes
chunhtai
chunhtai approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thank you for contributing! 🎉

@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Apr 11, 2023
@Piinks Piinks added autosubmit Merge PR when tree becomes green via auto submit App and removed f: material design flutter/packages/flutter/material repository. labels Apr 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 11, 2023

auto label is removed for flutter/flutter, pr: 124459, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Apr 11, 2023

Rebased to try to fix failing checks.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@gabrielgarciagava
Copy link
Contributor Author

gabrielgarciagava commented Apr 11, 2023

Rebased to try to fix failing checks.

Thanks. Let me know if there are other simple issues you would like me to check. I would like to start contributing more to the flutter framework.

@Piinks
Copy link
Contributor

Piinks commented Apr 11, 2023

@gabrielgarciagava glad to hear it! Welcome to the project!

@auto-submit auto-submit bot merged commit ee0b67d into flutter:master Apr 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
ee0b67d Exposed EdgeDraggingAutoScroller velocityScalar to Reorderabl…
2ec8e60 
…eList (flutter/flutter#124459)
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@gabrielgarciagava @exaby73
Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList (f…
72f8f08 
…lutter#124459)

Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList
@HansMuller HansMuller mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow built-in EdgeDraggingAutoScroller of ReorderableList/SliverReorderableList to be configured

3 participants

@gabrielgarciagava @Piinks @chunhtai