Re-land Lazily initialise Xcode installation status #10952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3e265e9. Rather than pre-compute Xcode install path, version, and EULA status, compute and cache on demand.
tvolkert
approved these changes
Jun 23, 2017
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
LGTM w/o tests since I know a follow-change that builds on this will fix/add tests :-)
Member
Author
|
Indeed. The irony of breakage caused by a change intended to get the code into a state where it's testable. Next patch does the extraction of the tool invocations into a mockable class. |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
This reverts commit 3e265e9. Rather than pre-compute Xcode install path, version, and EULA status, compute and cache on demand.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3e265e9 and re-lands bb8e2a7.
Rather than pre-compute Xcode install path, version, and EULA status,
compute and cache on demand.