Skip to content

[flutter_tool] Allow includes relative to shader path #107862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Jul 19, 2022
Merged

[flutter_tool] Allow includes relative to shader path #107862

zanderso merged 1 commit into from
Jul 19, 2022

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jul 18, 2022 •
edited
Loading

This PR passes --include=$shaderDir to impellerc.

Related: #107812

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 18, 2022
jonahwilliams
jonahwilliams approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit e9529e2 into flutter:master Jul 19, 2022
@zanderso zanderso deleted the impellerc-include branch July 19, 2022 01:38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c3d1919 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
7ab1c66 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
7fa4485 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
8244375 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
ab3f466 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
54f5e2e 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c075036 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c388854 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
1543ff8 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
2ec8bde 
…r/flutter#107862)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
24f979c 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
6ef68eb 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
9c6cd43 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c89280f 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
676f3c5 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c5860f0 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
f200792 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
3ce50d7 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c7021ba 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
c2b554f 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
7a74b01 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
6da10e9 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
b87a574 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
5f4b268 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
519eb31 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
93789a7 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
45e7b40 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
a8f6b50 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
37521f1 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
51a3967 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
d0c965e 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
d7c51a1 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
b2ad118 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
fa042df 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
68876c7 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
dc038e6 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
017898b 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
43a505b 
…r/flutter#107862)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e9529e2 [flutter_tool] Allow includes relative to shader path (flutte…
1c0dd95 
…r/flutter#107862)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@zanderso @camsim99
[flutter_tool] Allow includes relative to shader path (flutter#107862)
431367f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @chinmaygarde @jonahwilliams