-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Mac_android run_release_test
in presubmit
#106709
Skip Mac_android run_release_test
in presubmit
#106709
Conversation
@@ -3119,6 +3119,7 @@ targets: | |||
|
|||
- name: Mac_android run_release_test | |||
recipe: devicelab/devicelab_drone | |||
presubmit: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it not flaky post-submit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, no flake in recent 100 builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builder
Mac_android run_release_test
has been very flaky in pre-submit and affecting CQ workflows.This PR skips the test in pre-submit.
Context: this builder was added to cover
Mac_android
test bed config in pre-submit: #96539. As of now, we have another builderMac_android entrypoint_dart_registrant
running with consistent success, it is safe to removeMac_android run_release_test
from pre-submit to unblock the workflow without sacrificing the coverage.