[flutter_tools] tool exit from flutter create when provided just a drive letter #106451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
zanderso
reviewed
Jun 23, 2022
| /// `dart:io` does not recognize strings matching this pattern as absolute | ||
| /// paths, as they have no top level back-slash; however, users often specify | ||
| /// this | ||
| static final RegExp _kWindowsDrivePattern = RegExp(r'^[A-Z]:$'); |
There was a problem hiding this comment.
Is there anything helpful in package:path instead of potentially duplicating this logic?
There was a problem hiding this comment.
I see rootPattern, but that is a superset of what we want here, including a trailing slash (this is the same pattern that dart:io uses).
However, from looking at that, I can see that this regex should include lower-case letters.
There was a problem hiding this comment.
oh wait, never mind, this helper looks like it does the trick: https://github.com/dart-lang/path/blob/master/lib/src/utils.dart#L18
There was a problem hiding this comment.
I saw that, but couldn't tell if it was public.
There was a problem hiding this comment.
Shucks, it isn't exported
loic-sharma
approved these changes
Jun 24, 2022
zanderso
approved these changes
Jun 24, 2022
christopherfujino
deleted the
tool-exit-on-flutter-create-with-drive-letter
branch
This was referenced Jun 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 25, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 25, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 26, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 27, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 27, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 27, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
…ust a drive letter (flutter/flutter#106451)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…ust a drive letter (flutter/flutter#106451)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…ust a drive letter (flutter/flutter#106451)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104544
As described on the bug, the core problem is that
dart:iodoes not considerD:an absolute path and thus treats it like a relative path and prepends it with the current working directory: https://github.com/dart-lang/sdk/blob/main/sdk/lib/io/file_system_entity.dart#L571.Creating an app at the root of a drive is probably a user error anyway (they probably want it contained in a folder), so we tool exit with instructions on how to create it in a folder at the top level of the drive, or alternatively to specify
D:\if they really want it at the root of the drive.