Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_plugin_tools] Support configuration files for exclusion lists #86799

Closed
stuartmorgan opened this issue Jul 21, 2021 · 1 comment · Fixed by flutter/plugins#4183
Closed

[flutter_plugin_tools] Support configuration files for exclusion lists #86799

stuartmorgan opened this issue Jul 21, 2021 · 1 comment · Fixed by flutter/plugins#4183
Assignees
@stuartmorgan
Labels
p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@stuartmorgan
Copy link
Contributor

As I'm converting more of our test scripts to fail-if-no-tests to avoid the unfortunately-common pattern of us discovering that various tests weren't actually being run (e.g., because they were in the wrong location), .cirrus.yml is getting more and more information embedded into it about what tests should and shouldn't run. This has several drawbacks:

  • It clutters the CI config, which should describe at a high level what we are running and how, with details.
  • It doesn't translate to other CI system (e.g., our Windows tests that are run on LUCI).
  • It doesn't apply when running locally, so it's annoying to try to run a command on the whole repo locally.

We have the same issue with the "allow custom analysis" list, which has most of the same problems (and works against the goal of eliminating the use of shell scripts in the repo)
@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list labels Jul 21, 2021
@stuartmorgan stuartmorgan self-assigned this Jul 21, 2021
@stuartmorgan stuartmorgan mentioned this issue Jul 22, 2021
Merged
11 tasks
stuartmorgan added a commit to flutter/plugins that referenced this issue Jul 22, 2021
@stuartmorgan
[flutter_plugin_tools] Support YAML exception lists (#4183)
758c55e 
Currently the tool accepts `--custom-analysis` to allow a list of packages for which custom `analysis_options.yaml` are allowed, and `--exclude` to exclude a set of packages when running a command against all, or all changed, packages. This results in these exception lists being embedded into CI configuration files (e.g., .cirrus.yaml) or scripts, which makes them harder to maintain, and harder to re-use in other contexts (local runs, new CI systems).

This adds support for both flags to accept paths to YAML files that contain the lists, so that they can be maintained separately, and with inline comments about the reasons things are on the lists.

Also updates the CI to use this new support, eliminating those lists from `.cirrus.yaml` and `tool_runner.sh`

Fixes flutter/flutter#86799
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this issue Sep 13, 2021
@stuartmorgan @fotiDim
[flutter_plugin_tools] Support YAML exception lists (flutter#4183)
494fe48 
Currently the tool accepts `--custom-analysis` to allow a list of packages for which custom `analysis_options.yaml` are allowed, and `--exclude` to exclude a set of packages when running a command against all, or all changed, packages. This results in these exception lists being embedded into CI configuration files (e.g., .cirrus.yaml) or scripts, which makes them harder to maintain, and harder to re-use in other contexts (local runs, new CI systems).

This adds support for both flags to accept paths to YAML files that contain the lists, so that they can be maintained separately, and with inline comments about the reasons things are on the lists.

Also updates the CI to use this new support, eliminating those lists from `.cirrus.yaml` and `tool_runner.sh`

Fixes flutter/flutter#86799
amantoux pushed a commit to amantoux/plugins that referenced this issue Sep 27, 2021
@stuartmorgan @amantoux
[flutter_plugin_tools] Support YAML exception lists (flutter#4183)
2327ab9 
Currently the tool accepts `--custom-analysis` to allow a list of packages for which custom `analysis_options.yaml` are allowed, and `--exclude` to exclude a set of packages when running a command against all, or all changed, packages. This results in these exception lists being embedded into CI configuration files (e.g., .cirrus.yaml) or scripts, which makes them harder to maintain, and harder to re-use in other contexts (local runs, new CI systems).

This adds support for both flags to accept paths to YAML files that contain the lists, so that they can be maintained separately, and with inline comments about the reasons things are on the lists.

Also updates the CI to use this new support, eliminating those lists from `.cirrus.yaml` and `tool_runner.sh`

Fixes flutter/flutter#86799
stuartmorgan added a commit to flutter/packages that referenced this issue Feb 13, 2023
@stuartmorgan
[flutter_plugin_tools] Support YAML exception lists (#4183)
d17489c 
Currently the tool accepts `--custom-analysis` to allow a list of packages for which custom `analysis_options.yaml` are allowed, and `--exclude` to exclude a set of packages when running a command against all, or all changed, packages. This results in these exception lists being embedded into CI configuration files (e.g., .cirrus.yaml) or scripts, which makes them harder to maintain, and harder to re-use in other contexts (local runs, new CI systems).

This adds support for both flags to accept paths to YAML files that contain the lists, so that they can be maintained separately, and with inline comments about the reasons things are on the lists.

Also updates the CI to use this new support, eliminating those lists from `.cirrus.yaml` and `tool_runner.sh`

Fixes flutter/flutter#86799
ValentinVignal pushed a commit to ValentinVignal/flutter__packages that referenced this issue Feb 23, 2023
@stuartmorgan
[flutter_plugin_tools] Support YAML exception lists (flutter#4183)
92ec8e3 
Currently the tool accepts `--custom-analysis` to allow a list of packages for which custom `analysis_options.yaml` are allowed, and `--exclude` to exclude a set of packages when running a command against all, or all changed, packages. This results in these exception lists being embedded into CI configuration files (e.g., .cirrus.yaml) or scripts, which makes them harder to maintain, and harder to re-use in other contexts (local runs, new CI systems).

This adds support for both flags to accept paths to YAML files that contain the lists, so that they can be maintained separately, and with inline comments about the reasons things are on the lists.

Also updates the CI to use this new support, eliminating those lists from `.cirrus.yaml` and `tool_runner.sh`

Fixes flutter/flutter#86799
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[flutter_plugin_tools] Support YAML exception lists stuartmorgan/plugins
1 participant
@stuartmorgan