This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow per-platform customization of the default Skia font manager #8358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Mar 28, 2019
The font manager returned by SkFontMgr::RefDefault is determined by Skia's build configuration flags. Embedders may want to use a default font manager other than the one selected by their build of Skia.
jason-simmons
force-pushed
the
skfontmgr_platform_default
branch
from
34faa04 to
5afae80
Compare
mehmetf
approved these changes
Mar 28, 2019
Contributor
mehmetf
left a comment
mehmetf
left a comment
There was a problem hiding this comment.
LGTM. We can include one of these files based on platform. The roller needs to be aware of this.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2019
flutter/engine@82765aa...a1a2129 git log 82765aa..a1a2129 --no-merges --oneline a1a2129 GN Format all files in the engine. (flutter/engine#8369) 82c9104 Remove old Fuchsia external mem,sem extensions 6d1a6a4 Allow per-platform customization of the default Skia font manager (flutter/engine#8358) 3de50b8 Roll src/third_party/skia 84a53268af92..7eeb74fdfd84 (3 commits) (flutter/engine#8367) 65837ab Roll src/third_party/skia a2cec203eea8..84a53268af92 (1 commits) (flutter/engine#8366) ada0a8e Roll src/third_party/skia 57b7a792bb6f..a2cec203eea8 (1 commits) (flutter/engine#8365) 9729f1a Roll src/third_party/skia bf4229cc10a1..57b7a792bb6f (5 commits) (flutter/engine#8364) 23e0c37 Roll src/third_party/skia 01fe26360660..bf4229cc10a1 (6 commits) (flutter/engine#8363) fd0b440 Roll src/third_party/skia cc8c7bee7925..01fe26360660 (10 commits) (flutter/engine#8361) 96c9751 Rename threshold to access_threshold (flutter/engine#8354) 09a67fe update buildroot dep for flutter/buildroot@e2ca457 (flutter/engine#8359) 602b612 Reduce z-fighting on Scenic (flutter/engine#8318) b53e436 Roll src/third_party/dart a977273262..f29e100f42 (8 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…utter#8358) The font manager returned by SkFontMgr::RefDefault is determined by Skia's build configuration flags. Embedders may want to use a default font manager other than the one selected by their build of Skia.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ager (flutter#8358)" This reverts commit 4030013.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ager (flutter#8358)" This reverts commit 4030013.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font manager returned by SkFontMgr::RefDefault is determined by Skia's
build configuration flags. Embedders may want to use a default font manager
other than the one selected by their build of Skia.