This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Cleanups to run_tests.sh script #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor improvements to run_tests.sh: * Allow running from below the src/ buildroot dir, as it's often convenient to work from within the flutter/engine git dir. * Echo test name before running, for slightly better debuggability. * Minor line-wrapping for readability.
cbracken
commented
Mar 28, 2019
Member
Author
|
FWIW, I plan to follow up with similar tweaks to |
dnfield
approved these changes
Mar 28, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
I don't think this should impact the bots, LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 28, 2019
flutter/engine@37947f9...c4d14a0 git log 37947f9..c4d14a0 --no-merges --oneline c4d14a0 Roll src/third_party/skia e4c67058ddb1..01a065884b7d (1 commits) (flutter/engine#8344) 5983b7a Roll src/third_party/dart ffee99d79b..cf32584870 (6 commits) 84c62b4 Build Windows shell (flutter/engine#8331) 6415277 Roll src/third_party/skia 8d2c19554e4a..e4c67058ddb1 (1 commits) (flutter/engine#8341) a011010 Roll src/third_party/dart 991c9da720..ffee99d79b (7 commits) 2098398 Cleanups to run_tests.sh script (flutter/engine#8337) 5c99138 Build GLFW from source for Linux shell (flutter/engine#8327) 6800245 Fix Windows build. (flutter/engine#8336) 6d8b836 Remove use of epoxy from Linux shell (flutter/engine#8334) 4efc321 Add super call in FLEView reshape (flutter/engine#8335) cb8eb80 Allow embedders to specify their own task runner interfaces. (flutter/engine#8273) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
Bugfix: * Use the `pub` from within the built Dart SDK (not whatever's on `$PATH`, if anything). A few minor improvements: * Allow running from below the src/ buildroot dir, as it's often convenient to work from within the flutter/engine git dir. * Echo test name before running, for slightly better debuggability. * Minor line-wrapping for readability.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit eb82021.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit eb82021.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix:
pubfrom within the built Dart SDK (not whatever's on$PATH, if anything).A few minor improvements:
convenient to work from within the flutter/engine git dir.