This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Create a new resource loading EGL context for each PlatformView instance on Android #8330
Merged
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:resource_context_local
Mar 28, 2019
Merged
Create a new resource loading EGL context for each PlatformView instance on Android #8330
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:resource_context_local
Mar 28, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce on Android Using one global resource loading context will fail if two PlatformViews are running concurrently with two different IO threads.
dnfield
approved these changes
Mar 27, 2019
Contributor
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
This was referenced Mar 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
This was referenced Mar 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2019
…ew instance on Android (flutter/engine#8330)
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…nce on Android (flutter#8330) Using one global resource loading context will fail if two PlatformViews are running concurrently with two different IO threads.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ew instance on Android (flutter#8330)" This reverts commit f16022c.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ew instance on Android (flutter#8330)" This reverts commit f16022c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using one global resource loading context will fail if two PlatformViews are
running concurrently with two different IO threads.