This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Android Embedding PR 14: Almost done with FlutterFragment. #8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-carroll
requested review from
DaveShuckerow,
dnfield,
jason-simmons and
mklim
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java
Show resolved
Hide resolved
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java
Outdated
Show resolved
Hide resolved
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java
Outdated
Show resolved
Hide resolved
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java
Outdated
Show resolved
Hide resolved
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java
Show resolved
Hide resolved
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java
Outdated
Show resolved
Hide resolved
dnfield
reviewed
Mar 1, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java
Outdated
Show resolved
Hide resolved
mklim
reviewed
Mar 1, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM for Java style, pending one issue.
shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java
Show resolved
Hide resolved
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
matthew-carroll
force-pushed
the
android_embedding_refactor_pr14_more_flutter_fragment
branch
from
ed5ed69 to
819da7b
Compare
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 5, 2019
flutter/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter/engine#8043) flutter/engine@effee2f80 remove extra statement (flutter/engine#8041) flutter/engine@14e082fa0 (master) add lint script for Android with baseline (flutter/engine#8036) flutter/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter/engine#8040) flutter/engine@e6a5201f0 Add missing values to semantics action enums (flutter/engine#8033) flutter/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter/engine#8039) flutter/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter/engine#8037) flutter/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter/engine#8030) flutter/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter/engine#8035) flutter/engine@2cd9b41ba Select MPL instead of LGPL (flutter/engine#7991) flutter/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits) flutter/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter/engine#8000) flutter/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter/engine#8029) flutter/engine@36ca5740c (flutter/engine#8026) flutter/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter/engine#8028) flutter/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits) flutter/engine@a2246c199 Start of linting Android embedding (flutter/engine#8023) flutter/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter/engine#8024)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2019
flutter/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter/engine#8043) flutter/engine@effee2f80 remove extra statement (flutter/engine#8041) flutter/engine@14e082fa0 (master) add lint script for Android with baseline (flutter/engine#8036) flutter/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter/engine#8040) flutter/engine@e6a5201f0 Add missing values to semantics action enums (flutter/engine#8033) flutter/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter/engine#8039) flutter/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter/engine#8037) flutter/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter/engine#8030) flutter/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter/engine#8035) flutter/engine@2cd9b41ba Select MPL instead of LGPL (flutter/engine#7991) flutter/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits) flutter/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter/engine#8000) flutter/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter/engine#8029) flutter/engine@36ca5740c (flutter/engine#8026) flutter/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter/engine#8028) flutter/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits) flutter/engine@a2246c199 Start of linting Android embedding (flutter/engine#8023) flutter/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter/engine#8024)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more behavior to
FlutterFragmentto bring it up to date with the staging branch.After this PR, the only behavior that has not been migrated for
FlutterFragmentis splash screen behavior, which I'm re-spec'ing now to ensure we solve the right problem.There are TODO concerns in this PR regarding the
PlatformPluginand also a call intoFlutterView. I'll need to think deeper about these issues so I've pushed them off to a future PR.