Remove obsolete discovery mechanism from FlutterView #6157

jason-simmons · 2018-09-04T22:53:14Z

No description provided.

jason-simmons · 2018-09-04T22:54:02Z

@chinmaygarde @matthew-carroll

cbracken · 2018-09-04T23:00:04Z

matthew-carroll · 2018-09-04T23:00:52Z

Can we get some historical context for the record? What was this used for previously and why is it no longer needed?

PS - I just removed the same thing from my refactor work to match this PR.

jason-simmons · 2018-09-05T00:14:06Z

This was added to provide a way for IDE users to attach the debugger to a running Flutter app that wasn't launched through the IDE.

The tooling would issue a broadcast intent via adb, and all Flutter apps running on the device in debug mode would respond by writing an observatory endpoint to the Android log. The IDE could then ask the user to select an app and then establish a debug connection.

I had implemented this flow as an experiment in the old Flutter Atom plugin, but I don't think it got much use. The current tools do not make use of this.

flutter/engine@de4c7a5...3a7d0b5 git log de4c7a5..3a7d0b5 --no-merges --oneline 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...0981731 git log de4c7a5..0981731 --no-merges --oneline 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...e6d9b34 git log de4c7a5..e6d9b34 --no-merges --oneline e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...a0f30b3 git log de4c7a5..a0f30b3 --no-merges --oneline a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...f6ad3e0 git log de4c7a5..f6ad3e0 --no-merges --oneline f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...108e0a6 git log de4c7a5..108e0a6 --no-merges --oneline 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...572753f git log de4c7a5..572753f --no-merges --oneline 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...ade0f22 git log de4c7a5..ade0f22 --no-merges --oneline ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...1768bed git log de4c7a5..1768bed --no-merges --oneline 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...897178c git log de4c7a5..897178c --no-merges --oneline 897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182) 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...5f61056 git log de4c7a5..5f61056 --no-merges --oneline 5f61056 Revert "Dart SDK roll for 2018/09/04 (flutter#6161)" (flutter/engine#6183) 897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182) 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@de4c7a5...5f61056 git log de4c7a5..5f61056 --no-merges --oneline 5f61056 Revert "Dart SDK roll for 2018/09/04 (#6161)" (flutter/engine#6183) 897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182) 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

…er#6157

…erer (#6195) * Copied over FlutterView. Copied a number of dependencies due to package change. Grouped related methods within FlutterView. Deleted a few unused methods. * Moved BinaryMessenger out of FlutterView and into FlutterEngine, moved native calls from FlutterView to FlutterEngine. * Introduced concept of a FlutterRenderer. It doesn't have any meaningful behavior yet. Need strategy for resolving FlutterNativeView vs FlutterEngine first. * Removed discovery behavior from FlutterView to match recent PR: #6157 * Replaced FlutterNativeView with FlutterEngine and FlutterRenderer. Eliminated FlutterEngine references from within FlutterView. Centralized all JNI calls within a FlutterJNI and updated the C side accordingly. * Added comments to FlutterEngine, FlutterRender, FlutterFragment, and FlutterView. * Removed some extraneous code. Adjusted first frame notification slightly. * Fixed formatting in platform_view_android_jni.cc * Update licenses file. * Exposed FlutterEngine from plugin system. Updated some access modifiers as needed. * PR Updates.

…erer (flutter#6195) * Copied over FlutterView. Copied a number of dependencies due to package change. Grouped related methods within FlutterView. Deleted a few unused methods. * Moved BinaryMessenger out of FlutterView and into FlutterEngine, moved native calls from FlutterView to FlutterEngine. * Introduced concept of a FlutterRenderer. It doesn't have any meaningful behavior yet. Need strategy for resolving FlutterNativeView vs FlutterEngine first. * Removed discovery behavior from FlutterView to match recent PR: flutter#6157 * Replaced FlutterNativeView with FlutterEngine and FlutterRenderer. Eliminated FlutterEngine references from within FlutterView. Centralized all JNI calls within a FlutterJNI and updated the C side accordingly. * Added comments to FlutterEngine, FlutterRender, FlutterFragment, and FlutterView. * Removed some extraneous code. Adjusted first frame notification slightly. * Fixed formatting in platform_view_android_jni.cc * Update licenses file. * Exposed FlutterEngine from plugin system. Updated some access modifiers as needed. * PR Updates.

Remove obsolete discovery mechanism from FlutterView

a2e681e

googlebot added the cla: yes label Sep 4, 2018

chinmaygarde approved these changes Sep 4, 2018

View reviewed changes

cbracken approved these changes Sep 4, 2018

View reviewed changes

jason-simmons merged commit 6af60d7 into flutter:master Sep 5, 2018

engine-flutter-autoroll mentioned this pull request Sep 5, 2018

Roll engine de4c7a53f21c..3a7d0b559fe9 (20 commits) flutter/flutter#21450

Closed

engine-flutter-autoroll mentioned this pull request Sep 5, 2018

Roll engine de4c7a53f21c..0981731fd703 (21 commits) flutter/flutter#21452

Closed

engine-flutter-autoroll mentioned this pull request Sep 5, 2018

Roll engine de4c7a53f21c..e6d9b34a8cef (23 commits) flutter/flutter#21454

Closed

engine-flutter-autoroll mentioned this pull request Sep 5, 2018

Roll engine de4c7a53f21c..a0f30b3b0c03 (24 commits) flutter/flutter#21460

Closed

engine-flutter-autoroll mentioned this pull request Sep 6, 2018

Roll engine de4c7a53f21c..f6ad3e0967d1 (25 commits) flutter/flutter#21467

Closed

engine-flutter-autoroll mentioned this pull request Sep 6, 2018

Roll engine de4c7a53f21c..108e0a64eff5 (26 commits) flutter/flutter#21470

Closed

This was referenced Sep 6, 2018

Roll engine de4c7a53f21c..572753fb1205 (27 commits) flutter/flutter#21472

Closed

Roll engine de4c7a53f21c..ade0f2230371 (28 commits) flutter/flutter#21479

Closed

engine-flutter-autoroll mentioned this pull request Sep 6, 2018

Roll engine de4c7a53f21c..1768bedcf935 (29 commits) flutter/flutter#21491

Closed

engine-flutter-autoroll mentioned this pull request Sep 6, 2018

Roll engine de4c7a53f21c..897178cc3a52 (30 commits) flutter/flutter#21498

Closed

engine-flutter-autoroll mentioned this pull request Sep 6, 2018

Roll engine de4c7a53f21c..5f61056946ef (31 commits) flutter/flutter#21502

Merged

matthew-carroll pushed a commit to matthew-carroll/engine that referenced this pull request Sep 7, 2018

Removed discovery behavior from FlutterView to match recent PR: flutt…

e32b9d3

…er#6157

matthew-carroll pushed a commit to matthew-carroll/engine that referenced this pull request Sep 7, 2018

Removed discovery behavior from FlutterView to match recent PR: flutt…

657449d

…er#6157

matthew-carroll pushed a commit to matthew-carroll/engine that referenced this pull request Sep 7, 2018

Removed discovery behavior from FlutterView to match recent PR: flutt…

26d8ef6

…er#6157

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Remove obsolete discovery mechanism from FlutterView (flutter#6157)

4b1bd7b

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Remove obsolete discovery mechanism from FlutterView (flutter#6157)

4ef1c9a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove obsolete discovery mechanism from FlutterView #6157

Remove obsolete discovery mechanism from FlutterView #6157

Uh oh!

jason-simmons commented Sep 4, 2018

Uh oh!

jason-simmons commented Sep 4, 2018

Uh oh!

cbracken commented Sep 4, 2018

Uh oh!

matthew-carroll commented Sep 4, 2018

Uh oh!

jason-simmons commented Sep 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Remove obsolete discovery mechanism from FlutterView #6157

Remove obsolete discovery mechanism from FlutterView #6157

Uh oh!

Conversation

jason-simmons commented Sep 4, 2018

Uh oh!

jason-simmons commented Sep 4, 2018

Uh oh!

cbracken commented Sep 4, 2018

Uh oh!

matthew-carroll commented Sep 4, 2018

Uh oh!

jason-simmons commented Sep 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants