Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@endpress
Copy link
Contributor

@endpress endpress commented Sep 4, 2018

screen shot 2018-09-04 at 10 44 00 am

screen shot 2018-09-04 at 10 44 36 am

@endpress endpress changed the title fix sometime flutter view become black Fix sometime flutter view become black Sep 4, 2018
@endpress
Copy link
Contributor Author

endpress commented Sep 4, 2018

When push a native view from flutter view and pop back, some region of flutter view become black, and when you click the black region, it becomes normal. I upload a screen recording as a demostration.
ScreenRecording_09-04-2018 09-47-37.MP4.zip

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a sound change. I also think we should be clearing raster cache entries on when the compositor context is destroyed however. Can you add the same call to the other callback right below this one as well?

Thanks for the patch and apologies for the delay in the review.

@endpress endpress closed this Sep 6, 2018
@endpress endpress reopened this Sep 6, 2018
@endpress
Copy link
Contributor Author

endpress commented Sep 6, 2018

Sorry, I cannot understand you. Compositor context destroyed callback have called raster cache's clear function. So where should I add the call ?

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compositor context destroyed callback have called raster cache's clear function.

My bad. You're right. Looks good!

@chinmaygarde chinmaygarde merged commit e164e83 into flutter:master Sep 7, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@5f61056...e164e83

git log 5f61056..e164e83 --no-merges --oneline
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)
58a1894 Update to latest clang (flutter/engine#6174)
9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190)
e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160)
bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187)
30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186)
a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185)
058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@5f61056...b09563b

git log 5f61056..b09563b --no-merges --oneline
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)
58a1894 Update to latest clang (flutter/engine#6174)
9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190)
e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160)
bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187)
30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186)
a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185)
058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@9b297b3...75f6bdf

git log 9b297b3..75f6bdf --no-merges --oneline
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)
58a1894 Update to latest clang (flutter/engine#6174)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...5a19d76

git log 58a1894..5a19d76 --no-merges --oneline
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...85d47fb

git log 58a1894..85d47fb --no-merges --oneline
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...687cf08

git log 58a1894..687cf08 --no-merges --oneline
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...2af72eb

git log 58a1894..2af72eb --no-merges --oneline
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...16c56af

git log 58a1894..16c56af --no-merges --oneline
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...93dac2a

git log 58a1894..93dac2a --no-merges --oneline
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2018
flutter/engine@58a1894...e27a2e9

git log 58a1894..e27a2e9 --no-merges --oneline
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2018
flutter/engine@58a1894...bf96dbe

git log 58a1894..bf96dbe --no-merges --oneline
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2018
flutter/engine@58a1894...b952331

git log 58a1894..b952331 --no-merges --oneline
b952331 Allow embedders to specify a custom GL proc address resolver. (flutter/engine#6204)
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2018
flutter/engine@58a1894...bf3c224

git log 58a1894..bf3c224 --no-merges --oneline
bf3c224 Roll src/third_party/skia 2810c856dfa2..a3dc329d1db1 (1 commits) (flutter/engine#6206)
b952331 Allow embedders to specify a custom GL proc address resolver. (flutter/engine#6204)
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants