This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace System.loadLibrary with ReLinker.loadLibrary() in FlutterJNI.loadLibrary()
#55095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
commented
Sep 11, 2024
added 4 commits
September 11, 2024 11:54
gmackall
commented
Sep 11, 2024
reidbaker
approved these changes
Sep 11, 2024
gmackall
added
the
autosubmit
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…rJNI.loadLibrary()` (flutter#55095) Could fix? flutter/flutter#83596 The communication on https://issuetracker.google.com/issues/346717090#comment2 recommends using [ReLinker](https://github.com/KeepSafe/ReLinker) to avoid a bug in how library loading interacts with the [Play delivery feature](https://developer.android.com/guide/playcore/feature-delivery) (used in turn by Flutter's deferred components). The ReLinker docs also suggest that if you have `minSdk` less than `23`, then you should be using ReLinker regardless, as `System.loadLibrary` is unreliable for other reasons. I don't have any strong evidence to suggest that either one of these two root causes is the definitive cause of flutter/flutter#83596, but it probably wouldn't hurt ð�¤· [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
…in `FlutterJNI.loadLibrary()` (flutter/engine#55095)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2024
Manual roll, because flutter/engine#55095 updates dependencies, and so it needs gradle lockfiles re generated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could fix? flutter/flutter#83596
The communication on https://issuetracker.google.com/issues/346717090#comment2 recommends using ReLinker to avoid a bug in how library loading interacts with the Play delivery feature (used in turn by Flutter's deferred components).
The ReLinker docs also suggest that if you have
minSdkless than23, then you should be using ReLinker regardless, asSystem.loadLibraryis unreliable for other reasons.I don't have any strong evidence to suggest that either one of these two root causes is the definitive cause of flutter/flutter#83596, but it probably wouldn't hurt 🤷
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.