This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use TRUE/FALSE consistently for gboolean values. #54768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code was using stbool true/false - use the gboolean values consistently.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 27, 2024
…154172) flutter/engine@b41ca79...7d751ac 2024-08-27 [email protected] Roll Skia from 9460a3136627 to 7d9054c4317d (1 revision) (flutter/engine#54799) 2024-08-27 [email protected] Roll Fuchsia Test Scripts from oGxqx29_HA1eEBnt9... to vIJGWtHj4Rdku9Ayv... (flutter/engine#54800) 2024-08-27 [email protected] Store a set of layers per view. (flutter/engine#54793) 2024-08-27 [email protected] Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) (flutter/engine#54798) 2024-08-27 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.3 to 1.8.4 (flutter/engine#54797) 2024-08-27 [email protected] Roll Skia from 78ebd463a911 to 56b353d1674a (1 revision) (flutter/engine#54795) 2024-08-27 [email protected] Use TRUE/FALSE consistently for gboolean values. (flutter/engine#54768) 2024-08-27 [email protected] Roll Skia from c9f157b2cc4c to 78ebd463a911 (1 revision) (flutter/engine#54792) 2024-08-26 [email protected] Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) (flutter/engine#54790) 2024-08-26 [email protected] Disable impeller cmake test until it is fixed (flutter/engine#54788) 2024-08-26 [email protected] macOS: Add @available check at macOS 12 workaround (flutter/engine#54784) 2024-08-26 [email protected] Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) (flutter/engine#54789) 2024-08-26 [email protected] macOS: Do not archive/upload FlutterMacOS.dSYM to cloud (flutter/engine#54787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#154172) flutter/engine@b41ca79...7d751ac 2024-08-27 [email protected] Roll Skia from 9460a3136627 to 7d9054c4317d (1 revision) (flutter/engine#54799) 2024-08-27 [email protected] Roll Fuchsia Test Scripts from oGxqx29_HA1eEBnt9... to vIJGWtHj4Rdku9Ayv... (flutter/engine#54800) 2024-08-27 [email protected] Store a set of layers per view. (flutter/engine#54793) 2024-08-27 [email protected] Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) (flutter/engine#54798) 2024-08-27 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.3 to 1.8.4 (flutter/engine#54797) 2024-08-27 [email protected] Roll Skia from 78ebd463a911 to 56b353d1674a (1 revision) (flutter/engine#54795) 2024-08-27 [email protected] Use TRUE/FALSE consistently for gboolean values. (flutter/engine#54768) 2024-08-27 [email protected] Roll Skia from c9f157b2cc4c to 78ebd463a911 (1 revision) (flutter/engine#54792) 2024-08-26 [email protected] Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) (flutter/engine#54790) 2024-08-26 [email protected] Disable impeller cmake test until it is fixed (flutter/engine#54788) 2024-08-26 [email protected] macOS: Add @available check at macOS 12 workaround (flutter/engine#54784) 2024-08-26 [email protected] Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) (flutter/engine#54789) 2024-08-26 [email protected] macOS: Do not archive/upload FlutterMacOS.dSYM to cloud (flutter/engine#54787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code was using stbool true/false - use the gboolean values consistently.