Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,24 @@ DownsamplePassArgs CalculateDownsamplePassArgs(
Rect source_rect_padded = source_rect.Expand(padding);
Vector2 downsampled_size = source_rect_padded.GetSize() * downsample_scalar;
ISize subpass_size =
ISize(round(downsampled_size.x), round(downsampled_size.y));
ISize(ceil(downsampled_size.x), ceil(downsampled_size.y));
Vector2 divisible_size(CeilToDivisible(source_rect_padded.GetSize().width,
1.0 / downsample_scalar.x),
CeilToDivisible(source_rect_padded.GetSize().height,
1.0 / downsample_scalar.y));
// Only make the padding divisible if we already have padding. If we don't
// have padding adding more can add artifacts to hard blur edges.
Vector2 divisible_padding(
padding.x > 0
? padding.x +
(divisible_size.x - source_rect_padded.GetSize().width) / 2.0
: 0.f,
padding.y > 0
? padding.y +
(divisible_size.y - source_rect_padded.GetSize().height) / 2.0
: 0.f);
source_rect_padded = source_rect.Expand(divisible_padding);

Vector2 effective_scalar =
Vector2(subpass_size) / source_rect_padded.GetSize();
Quad uvs = GaussianBlurFilterContents::CalculateUVs(
Expand All @@ -312,8 +329,8 @@ DownsamplePassArgs CalculateDownsamplePassArgs(
.subpass_size = subpass_size,
.uvs = uvs,
.effective_scalar = effective_scalar,
.transform =
input_snapshot.transform * Matrix::MakeTranslation(-padding),
.transform = input_snapshot.transform *
Matrix::MakeTranslation(-divisible_padding),
};
}
}
Expand Down