This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Respect the respect_ctm flag for mask blurred text & absorb entity scale when rendering the 2-pass blur input. #53368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b entity scale when rendering the 2-pass blur input.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@gaaclarke I'm pushing this PR to see those goldens, but if you want to take this over or add some more testing stuff feel free to just push a new PR and we can merge that. : ) |
| } | ||
|
|
||
| namespace { | ||
| Vector2 ExtractScale(const Matrix& matrix) { |
Contributor
There was a problem hiding this comment.
I think we can use Matrix::Decompose for this
Contributor
|
Respect |
Member
|
I cherry-picked Brandon's I'll add some tests and update the coverage tests/math then send it out for review. Thanks so much brandon and jonah for hunting that flag down. |
Member
|
Oh yea, and I think the gaussian blur is long overdue a comments refresh. I think we are stabilizing enough to build the docs out. |
Member
Author
|
Okie dokie, closing this out. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#142014
Resolves flutter/flutter#150114
This is a combination of:
DlMaskBlurFilter(thanks to @jonahwilliams for recalling this bug).Let's see those goldens.
Skia
Impeller
Play/DlGoldenTest.GaussianVsRRectBlur/Metal