[impeller] switches gaussian blur to a "source space" calculation #53261

gaaclarke · 2024-06-06T21:25:24Z

fixes flutter/flutter#149781
fixes flutter/flutter#149458
fixes flutter/flutter#140890

This works by performing the blur in the axis aligned "source space" (as opposed to "global space"). The rotation and scaling then is applied to the result of the gaussian blur. Previously the differences between rrect_blur and gaussian blur were "fixed" in #53130 which worked for blurring content that had no signal. This addresses that same problem but in a more correct way that is less prone to artifacts when translating a blur since the blur happens in "source space".

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2024-06-06T22:49:03Z

I've updated the rendering code, now I have to migrate that math over to the coverage math.

flutter-dashboard · 2024-06-06T22:51:25Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

jonahwilliams · 2024-06-06T23:00:15Z

Does this also address flutter/flutter#140890 ?

gaaclarke · 2024-06-07T16:10:04Z

Does this also address flutter/flutter#140890 ?

Yep, thanks.

flutter-dashboard · 2024-06-07T18:28:33Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #53261 at sha bae3001

gaaclarke · 2024-06-07T18:29:05Z

The golden results mostly look good. There is some weird results in the mask blur tests though, for instance this one seems to be drawing shapes that shouldn't exist:

gaaclarke · 2024-06-07T21:41:23Z

Everything is looking good now. The 2 problems that had to be fixed was that the zero sigma fast path didn't have its math updated and the same goes for the drawing of the snapshot that happens over the solid blur style.

flutter-dashboard · 2024-06-07T21:41:36Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #53261 at sha 3a25e10

gaaclarke · 2024-06-07T23:45:00Z

For flutter/flutter#149458 I can see the blur is unidirectional now, but there is still a difference in overall blur size between Skia and Impeller...

I left the golden differences untriaged so you can review them as part of looking at this PR. The size of the blur radius hasn't changed as a result of this PR for any of the cases we measure. If we are missing a test we should file a new issue.

flar · 2024-06-07T23:49:32Z

For flutter/flutter#149458 I can see the blur is unidirectional now, but there is still a difference in overall blur size between Skia and Impeller...

I left the golden differences untriaged so you can review them as part of looking at this PR. The size of the blur radius hasn't changed as a result of this PR for any of the cases we measure. If we are missing a test we should file a new issue.

The test case in that issue that you say is fixed is still showing a difference between Skia and Impeller. This isn't an Impeller->Impeller difference, it is an inconsistency in current Impeller behavior vs pre-Impeller behavior and it is very noticeable (i.e. not off by a few %, but off by what looks like 20-30% on the size of the blur). This was tested using the test case in that issue and using the changes in this PR.

The main issue reported there is that the blur wasn't unidirectional and that is fixed, but that same test case still shows that the blur sizes are inconsistent with legacy (i.e. Skia) behavior - so maybe that gets addressed in a new Issue/PR combo...

gaaclarke · 2024-06-07T23:52:06Z

The main issue reported there is that the blur wasn't unidirectional and that is fixed, but that same test case still shows that the blur sizes are inconsistent with legacy (i.e. Skia) behavior - so maybe that gets addressed in a new Issue/PR combo...

Sounds good, can you file an issue please and cc me.

flar

The blur size difference should be filed as a new issue, but the change improves the non-uniform blur behavior significantly...

flar · 2024-06-08T00:00:29Z

I left the golden differences untriaged so you can review them as part of looking at this PR. The size of the blur radius hasn't changed as a result of this PR for any of the cases we measure. If we are missing a test we should file a new issue.

I didn't triage them, but there were some differences that I thought you should take a look at and see if you are happy with them.

flar · 2024-06-08T00:12:04Z

Filed flutter/flutter#149943

…lation (flutter/engine#53261)

…150069) Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 revisions) flutter/engine@1cdbebe...c7fcbfc 2024-06-11 [email protected] Fix character getter API usage in stripLeftSlashes/stripRightSlashes (flutter/engine#53299) 2024-06-11 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53134) 2024-06-11 [email protected] Roll Dart SDK from 282b3347dc3e to ab4d5a0b789d (1 revision) (flutter/engine#53338) 2024-06-11 [email protected] [Flutter GPU] Generate DescriptorSetLayouts for pipelines & export symbols on Android. (flutter/engine#53184) 2024-06-11 [email protected] Roll Skia from cd2249d1ba33 to b5f974ec2dcd (4 revisions) (flutter/engine#53337) 2024-06-11 [email protected] [Impeller] remove varying interpolation for solid colors. (flutter/engine#53281) 2024-06-11 [email protected] Roll Skia from 67c3ee616fb5 to cd2249d1ba33 (4 revisions) (flutter/engine#53335) 2024-06-11 [email protected] [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. (flutter/engine#53334) 2024-06-11 [email protected] Manual roll Dart SDK from 66ed61abe85e to 282b3347dc3e (4 revisions) (flutter/engine#53332) 2024-06-11 [email protected] Roll Skia from 74061baa5402 to 67c3ee616fb5 (2 revisions) (flutter/engine#53333) 2024-06-11 [email protected] Roll Skia from f4d3467f2742 to 74061baa5402 (1 revision) (flutter/engine#53331) 2024-06-11 [email protected] Roll Skia from 5afbe0a7aded to f4d3467f2742 (1 revision) (flutter/engine#53330) 2024-06-11 [email protected] Roll Skia from eb8a53033e88 to 5afbe0a7aded (1 revision) (flutter/engine#53328) 2024-06-11 [email protected] Roll Skia from ed92d84ffd3a to eb8a53033e88 (1 revision) (flutter/engine#53327) 2024-06-11 [email protected] Roll Skia from 6e7a7a72cf3e to ed92d84ffd3a (5 revisions) (flutter/engine#53326) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.8 (flutter/engine#53325) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.3 to 1.7.4 (flutter/engine#53324) 2024-06-11 [email protected] Roll Skia from b2bc3608f5c7 to 6e7a7a72cf3e (1 revision) (flutter/engine#53323) 2024-06-11 [email protected] Manual roll Dart SDK from 235dc289e4bf to 66ed61abe85e (5 revisions) (flutter/engine#53319) 2024-06-11 [email protected] Roll Skia from 38733e27e0d2 to b2bc3608f5c7 (1 revision) (flutter/engine#53321) 2024-06-10 [email protected] Temporarily run Linux linux_web_engine Mac tests on Mac-13 only (flutter/engine#53318) 2024-06-10 [email protected] Roll Fuchsia Linux SDK from -oOBf1l63tk7CztFd... to LS0Ff8PwQEGXzO0iA... (flutter/engine#53317) 2024-06-10 [email protected] Map mouse pointer type on Linux (flutter/engine#52418) 2024-06-10 [email protected] Roll Skia from 09cebc502599 to 38733e27e0d2 (1 revision) (flutter/engine#53316) 2024-06-10 [email protected] Temporarily run Mac mac_host_engine on only Mac-13 (flutter/engine#53313) 2024-06-10 [email protected] Roll Skia from 178953621308 to 09cebc502599 (1 revision) (flutter/engine#53312) 2024-06-10 [email protected] Roll Skia from 009d184e82c5 to 178953621308 (2 revisions) (flutter/engine#53311) 2024-06-10 [email protected] Roll Skia from 163df01252cd to 009d184e82c5 (1 revision) (flutter/engine#53309) 2024-06-10 [email protected] Use dart.library.html to distinguish dart2wasm from dart2js/ddc in conditional imports (flutter/engine#53307) 2024-06-10 [email protected] Roll Skia from 74b1e88878e1 to 163df01252cd (1 revision) (flutter/engine#53308) 2024-06-10 [email protected] Use new dart:js_interop way to externalize/internalize objects (flutter/engine#53304) 2024-06-10 [email protected] Roll Skia from 09e5ddcd4d23 to 74b1e88878e1 (1 revision) (flutter/engine#53305) 2024-06-10 [email protected] Roll Skia from e22a628e1ee0 to 09e5ddcd4d23 (1 revision) (flutter/engine#53302) 2024-06-10 [email protected] Roll Skia from 70d479753d41 to e22a628e1ee0 (2 revisions) (flutter/engine#53301) 2024-06-10 [email protected] Roll Skia from aafc81dcd88d to 70d479753d41 (1 revision) (flutter/engine#53300) 2024-06-09 [email protected] Roll Fuchsia Linux SDK from 8-r8iw3r4h35XQ4GP... to -oOBf1l63tk7CztFd... (flutter/engine#53298) 2024-06-09 [email protected] Roll Skia from 7d410bf13546 to aafc81dcd88d (1 revision) (flutter/engine#53297) 2024-06-08 [email protected] [Impeller] Move SeparatedVector2 to impeller/geometry. (flutter/engine#53264) 2024-06-08 [email protected] Roll Fuchsia Linux SDK from zpBZmUB_JC5AjG-f4... to 8-r8iw3r4h35XQ4GP... (flutter/engine#53291) 2024-06-08 [email protected] Roll Skia from a6c905943fe6 to 7d410bf13546 (1 revision) (flutter/engine#53290) 2024-06-08 [email protected] Roll Dart SDK from 48c6249a5b97 to 235dc289e4bf (1 revision) (flutter/engine#53289) 2024-06-08 [email protected] Roll Skia from ad3c9f203f4e to a6c905943fe6 (1 revision) (flutter/engine#53288) 2024-06-08 [email protected] Roll Dart SDK from d4f17e0bf28b to 48c6249a5b97 (1 revision) (flutter/engine#53287) 2024-06-08 [email protected] [impeller] switches gaussian blur to a "source space" calculation (flutter/engine#53261) 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) ...

bdero · 2024-06-12T20:32:08Z

impeller/entity/contents/filters/gaussian_blur_filter_contents.cc

@@ -420,17 +416,28 @@ std::optional<Entity> GaussianBlurFilterContents::RenderFilter(
    mip_count = 1;
  }

+  Entity snapshot_entity = entity.Clone();
+  snapshot_entity.SetTransform(Matrix());


This will cause anything that's scaled up to be rendered at a resolution which is too low for accurate results.

Perhaps a good heuristic to use here would would be to extract the max basis length and apply it here.

…lutter#150069) Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 revisions) flutter/engine@1cdbebe...c7fcbfc 2024-06-11 [email protected] Fix character getter API usage in stripLeftSlashes/stripRightSlashes (flutter/engine#53299) 2024-06-11 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53134) 2024-06-11 [email protected] Roll Dart SDK from 282b3347dc3e to ab4d5a0b789d (1 revision) (flutter/engine#53338) 2024-06-11 [email protected] [Flutter GPU] Generate DescriptorSetLayouts for pipelines & export symbols on Android. (flutter/engine#53184) 2024-06-11 [email protected] Roll Skia from cd2249d1ba33 to b5f974ec2dcd (4 revisions) (flutter/engine#53337) 2024-06-11 [email protected] [Impeller] remove varying interpolation for solid colors. (flutter/engine#53281) 2024-06-11 [email protected] Roll Skia from 67c3ee616fb5 to cd2249d1ba33 (4 revisions) (flutter/engine#53335) 2024-06-11 [email protected] [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. (flutter/engine#53334) 2024-06-11 [email protected] Manual roll Dart SDK from 66ed61abe85e to 282b3347dc3e (4 revisions) (flutter/engine#53332) 2024-06-11 [email protected] Roll Skia from 74061baa5402 to 67c3ee616fb5 (2 revisions) (flutter/engine#53333) 2024-06-11 [email protected] Roll Skia from f4d3467f2742 to 74061baa5402 (1 revision) (flutter/engine#53331) 2024-06-11 [email protected] Roll Skia from 5afbe0a7aded to f4d3467f2742 (1 revision) (flutter/engine#53330) 2024-06-11 [email protected] Roll Skia from eb8a53033e88 to 5afbe0a7aded (1 revision) (flutter/engine#53328) 2024-06-11 [email protected] Roll Skia from ed92d84ffd3a to eb8a53033e88 (1 revision) (flutter/engine#53327) 2024-06-11 [email protected] Roll Skia from 6e7a7a72cf3e to ed92d84ffd3a (5 revisions) (flutter/engine#53326) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.8 (flutter/engine#53325) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.3 to 1.7.4 (flutter/engine#53324) 2024-06-11 [email protected] Roll Skia from b2bc3608f5c7 to 6e7a7a72cf3e (1 revision) (flutter/engine#53323) 2024-06-11 [email protected] Manual roll Dart SDK from 235dc289e4bf to 66ed61abe85e (5 revisions) (flutter/engine#53319) 2024-06-11 [email protected] Roll Skia from 38733e27e0d2 to b2bc3608f5c7 (1 revision) (flutter/engine#53321) 2024-06-10 [email protected] Temporarily run Linux linux_web_engine Mac tests on Mac-13 only (flutter/engine#53318) 2024-06-10 [email protected] Roll Fuchsia Linux SDK from -oOBf1l63tk7CztFd... to LS0Ff8PwQEGXzO0iA... (flutter/engine#53317) 2024-06-10 [email protected] Map mouse pointer type on Linux (flutter/engine#52418) 2024-06-10 [email protected] Roll Skia from 09cebc502599 to 38733e27e0d2 (1 revision) (flutter/engine#53316) 2024-06-10 [email protected] Temporarily run Mac mac_host_engine on only Mac-13 (flutter/engine#53313) 2024-06-10 [email protected] Roll Skia from 178953621308 to 09cebc502599 (1 revision) (flutter/engine#53312) 2024-06-10 [email protected] Roll Skia from 009d184e82c5 to 178953621308 (2 revisions) (flutter/engine#53311) 2024-06-10 [email protected] Roll Skia from 163df01252cd to 009d184e82c5 (1 revision) (flutter/engine#53309) 2024-06-10 [email protected] Use dart.library.html to distinguish dart2wasm from dart2js/ddc in conditional imports (flutter/engine#53307) 2024-06-10 [email protected] Roll Skia from 74b1e88878e1 to 163df01252cd (1 revision) (flutter/engine#53308) 2024-06-10 [email protected] Use new dart:js_interop way to externalize/internalize objects (flutter/engine#53304) 2024-06-10 [email protected] Roll Skia from 09e5ddcd4d23 to 74b1e88878e1 (1 revision) (flutter/engine#53305) 2024-06-10 [email protected] Roll Skia from e22a628e1ee0 to 09e5ddcd4d23 (1 revision) (flutter/engine#53302) 2024-06-10 [email protected] Roll Skia from 70d479753d41 to e22a628e1ee0 (2 revisions) (flutter/engine#53301) 2024-06-10 [email protected] Roll Skia from aafc81dcd88d to 70d479753d41 (1 revision) (flutter/engine#53300) 2024-06-09 [email protected] Roll Fuchsia Linux SDK from 8-r8iw3r4h35XQ4GP... to -oOBf1l63tk7CztFd... (flutter/engine#53298) 2024-06-09 [email protected] Roll Skia from 7d410bf13546 to aafc81dcd88d (1 revision) (flutter/engine#53297) 2024-06-08 [email protected] [Impeller] Move SeparatedVector2 to impeller/geometry. (flutter/engine#53264) 2024-06-08 [email protected] Roll Fuchsia Linux SDK from zpBZmUB_JC5AjG-f4... to 8-r8iw3r4h35XQ4GP... (flutter/engine#53291) 2024-06-08 [email protected] Roll Skia from a6c905943fe6 to 7d410bf13546 (1 revision) (flutter/engine#53290) 2024-06-08 [email protected] Roll Dart SDK from 48c6249a5b97 to 235dc289e4bf (1 revision) (flutter/engine#53289) 2024-06-08 [email protected] Roll Skia from ad3c9f203f4e to a6c905943fe6 (1 revision) (flutter/engine#53288) 2024-06-08 [email protected] Roll Dart SDK from d4f17e0bf28b to 48c6249a5b97 (1 revision) (flutter/engine#53287) 2024-06-08 [email protected] [impeller] switches gaussian blur to a "source space" calculation (flutter/engine#53261) 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) ...

gaaclarke added 5 commits June 6, 2024 09:45

[Impeller] fixes non-uniform gaussian blurs of non-textures

1846c0d

pulled out decompose function

e4795ed

it draws right for this one case

ec71008

removed some tests

4796abc

format

f5d442c

github-actions bot added the e: impeller label Jun 6, 2024

gaaclarke changed the title ~~Blur local coords~~ [impeller] switches gaussian blur to a "source space" calculation Jun 6, 2024

tidy

2685b7e

gaaclarke marked this pull request as draft June 6, 2024 22:46

gaaclarke added 3 commits June 7, 2024 09:47

made lack of a hint not a crash

b8394c1

temporarily turn off coverage test to get goldens

3b5067b

fixed coverage test and turned it back on

34d3455

gaaclarke marked this pull request as ready for review June 7, 2024 17:10

gaaclarke added 2 commits June 7, 2024 10:30

tidy and removed unnecessary check

7ffd89c

updated golden list

bae3001

flutter-dashboard bot added the will affect goldens label Jun 7, 2024

gaaclarke marked this pull request as draft June 7, 2024 18:29

gaaclarke added 2 commits June 7, 2024 13:39

fixed zero sigma path

d1a2c69

fixed solid blur style

3a25e10

gaaclarke marked this pull request as ready for review June 7, 2024 21:26

gaaclarke requested review from flar and bdero June 7, 2024 21:40

jim feedback

8a3188d

jim feedback 2

927c44e

gaaclarke requested a review from flar June 7, 2024 23:51

flar approved these changes Jun 7, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2024

flar mentioned this pull request Jun 8, 2024

Size difference between Impeller blur and legacy (Skia) blur flutter/flutter#149943

Open

auto-submit bot merged commit 81dca13 into flutter:main Jun 8, 2024
29 checks passed

engine-flutter-autoroll mentioned this pull request Jun 8, 2024

Roll Flutter Engine from 45cf05f7a580 to 81dca134aba1 (1 revision) flutter/flutter#149945

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2024

81dca134a [impeller] switches gaussian blur to a "source space" calcu…

0af4d6f

…lation (flutter/engine#53261)

engine-flutter-autoroll mentioned this pull request Jun 8, 2024

Roll Flutter Engine from 45cf05f7a580 to 18539fe51f2f (2 revisions) flutter/flutter#149948

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2024

81dca134a [impeller] switches gaussian blur to a "source space" calcu…

efab37a

…lation (flutter/engine#53261)

engine-flutter-autoroll mentioned this pull request Jun 8, 2024

Roll Flutter Engine from 45cf05f7a580 to d5e2d6206fff (3 revisions) flutter/flutter#149949

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2024

81dca134a [impeller] switches gaussian blur to a "source space" calcu…

fc3e862

…lation (flutter/engine#53261)

engine-flutter-autoroll mentioned this pull request Jun 8, 2024

Roll Flutter Engine from 45cf05f7a580 to d5e2d6206fff (3 revisions) flutter/flutter#149953

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2024

81dca134a [impeller] switches gaussian blur to a "source space" calcu…

fc1f8e7

…lation (flutter/engine#53261)

engine-flutter-autoroll mentioned this pull request Jun 8, 2024

Roll Flutter Engine from 45cf05f7a580 to d5e2d6206fff (3 revisions) flutter/flutter#149958

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2024

81dca134a [impeller] switches gaussian blur to a "source space" calcu…

a5d9039

…lation (flutter/engine#53261)

engine-flutter-autoroll mentioned this pull request Jun 11, 2024

Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 revisions) flutter/flutter#150069

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2024

81dca134a [impeller] switches gaussian blur to a "source space" calcu…

b9f6881

…lation (flutter/engine#53261)

gaaclarke mentioned this pull request Jun 11, 2024

[Impeller] "source space" blurs caused change in widgets.image_test.missing.2 flutter/flutter#150076

Closed

gaaclarke mentioned this pull request Jun 12, 2024

Text shadows now appear broken on iOS flutter/flutter#150114

Closed

bdero reviewed Jun 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[impeller] switches gaussian blur to a "source space" calculation #53261

[impeller] switches gaussian blur to a "source space" calculation #53261

gaaclarke commented Jun 6, 2024 •

edited

Loading

gaaclarke commented Jun 6, 2024

flutter-dashboard bot commented Jun 6, 2024

jonahwilliams commented Jun 6, 2024

gaaclarke commented Jun 7, 2024

flutter-dashboard bot commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

flutter-dashboard bot commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

flar commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

flar left a comment

flar commented Jun 8, 2024

flar commented Jun 8, 2024

bdero Jun 12, 2024

[impeller] switches gaussian blur to a "source space" calculation #53261

[impeller] switches gaussian blur to a "source space" calculation #53261

Conversation

gaaclarke commented Jun 6, 2024 • edited Loading

Pre-launch Checklist

gaaclarke commented Jun 6, 2024

flutter-dashboard bot commented Jun 6, 2024

jonahwilliams commented Jun 6, 2024

gaaclarke commented Jun 7, 2024

flutter-dashboard bot commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

flutter-dashboard bot commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

flar commented Jun 7, 2024

gaaclarke commented Jun 7, 2024

flar left a comment

Choose a reason for hiding this comment

flar commented Jun 8, 2024

flar commented Jun 8, 2024

bdero Jun 12, 2024

Choose a reason for hiding this comment

gaaclarke commented Jun 6, 2024 •

edited

Loading