This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] re-enable gold CTL. #52299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1ac3ce3.
Contributor
Author
…lyline generation. (flutter#52180)" This reverts commit 46ff024.
Contributor
Author
|
Also reverting #52180 |
This reverts commit f65777f.
Contributor
Author
|
Adding #52160 speculative revert |
matanlurey
approved these changes
Apr 22, 2024
gaaclarke
approved these changes
Apr 22, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
This approach sounds good to me, I'm not sure if we'll see more problems but looks good to me as it is now.
|
|
||
| TEST_P(AiksTest, CanDrawPoints) { | ||
| if (GetBackend() == PlaygroundBackend::kMetal) { | ||
| // https://github.com/flutter/flutter/issues/147184 |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 23, 2024
…147203) flutter/engine@33c828f...62c9f17 2024-04-22 [email protected] [Impeller] skip lineTo for empty contours. (flutter/engine#52290) 2024-04-22 [email protected] Roll Skia from 3b32e3280b67 to e6de04b82b57 (6 revisions) (flutter/engine#52304) 2024-04-22 [email protected] [Impeller] re-enable gold CTL. (flutter/engine#52299) 2024-04-22 [email protected] Roll Dart SDK from 0ed66a4d77cb to 95f95b3118fe (1 revision) (flutter/engine#52301) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add goldctl dependency to arm64
Fixes flutter/flutter#147180