[Impeller] only use framebuffer advanced blends if available. #52284
Conversation
| #include <memory> | ||
| #include <optional> | ||
|
|
||
| #include "fml/logging.h" |
impeller/entity/entity_unittests.cc
Outdated
| << "The ColorBurned texture wasn't allocated (100x100 scales up 2x)"; | ||
| } | ||
|
|
||
| // glyph_atlas_pipelines_.CreateDefault( |
There was a problem hiding this comment.
Nit: Did you mean to leave in this checked in comment?
| /// blend filters. | ||
| /// | ||
| /// This allows a substantial reduction in the number of bootstrapped filters. | ||
| std::optional<Entity> CreateFramebufferAdvancedBlend( |
There was a problem hiding this comment.
Also document the SupportsFramebufferFetch requirement?
There was a problem hiding this comment.
Framebuffer advanced blends vs the other kind (pipeline blend?) I think are our own inventions of terminology (which totally make sense). But it would be good to point it out either here or in a glossary.
| framebuffer_blend_softlight_pipelines_.CreateDefault( | ||
| *context_, options_trianglestrip, | ||
| {static_cast<Scalar>(BlendSelectValues::kSoftLight), supports_decal}); | ||
| } else { |
There was a problem hiding this comment.
Oh, I thought we were always doing this. So this is is only ever relevant on OpenGL ES and the desktop Metal (which I keep forgetting exists) stuff right?
There was a problem hiding this comment.
And iOS simulator!
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Hey golden diffs! Cool I have something to look at now. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
added
the
autosubmit
…147258) flutter/engine@f23cc4d...b686508 2024-04-23 [email protected] Roll Fuchsia Linux SDK from L533ubzhjWwW7jxbc... to le_-uFgRD5DjvvqgL... (flutter/engine#52329) 2024-04-23 [email protected] [Impeller] only use framebuffer advanced blends if available. (flutter/engine#52284) 2024-04-23 [email protected] [Impeller] drawVertices uber shader. (flutter/engine#52315) 2024-04-23 [email protected] Roll Dart SDK from acd54f86bdbb to 6a670b60eb06 (1 revision) (flutter/engine#52327) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from L533ubzhjWwW to le_-uFgRD5Dj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
This reduces the shader bootstrap count by 15.
Instead of using the regular advanced blend filters for BlendFilters, start a render pass and use the framebuffer advanced blend.
part of flutter/flutter#143540