This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update fuchsia_libs.gni #51447
Merged
Update fuchsia_libs.gni #51447
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation of the change: The Fuchsia SDK target //sdk/lib/vfs/cpp is being migrated to a shared library in https://fxrev.dev/981373. The shared library has already been included in the SDK as a dependency, but is missing from the OOT copies of the runners used in tests (shell/platform/fuchsia/flutter/src.gn). This change adds the missing .so to these prebuilts. ### Blocking issue: As part of an ongoing Fuchsia SDK migration effort, this library requires migration in order to continue ongoing maintenance efforts. See https://fxbug.dev/293936429 for details. ### Solutions: This library is already included and licensed under the exsting Fuchsia SDK license. It can be verified as already existing in the distributed IDKs due to it being added as a dependency early. The OOT test archives are the last remaining step before switching the library to start using the new .so. Bug: [b/293936429](https://fxbug.dev/293936429) FYI: @ZiJieHe [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
zanderso
approved these changes
Mar 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 19, 2024
…145424) flutter/engine@7095e6a...bacb027 2024-03-19 6844906[email protected] [Fuchsia] Remove the legacy tools/fuchsia/target_api_level file (flutter/engine#51497) 2024-03-19 [email protected] Update fuchsia_libs.gni (flutter/engine#51447) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation of the change:
The Fuchsia SDK target //sdk/lib/vfs/cpp is being migrated to a shared library in https://fxrev.dev/981373. The shared library has already been included in the SDK as a dependency, but is missing from the OOT copies of the runners used in tests (shell/platform/fuchsia/flutter/BUILD.gn). This change adds the missing .so to these prebuilts.
Blocking issue:
As part of an ongoing Fuchsia SDK migration effort, this library requires migration in order to continue ongoing maintenance efforts. See https://fxbug.dev/293936429 for details.
Solutions:
This library is already included licensed under the exsting Fuchsia SDK license. It can be verified as already existing in the distributed IDKs due to it being added as a dependency early. The OOT test archives are the last remaining step before switching the library to start using the new .so.
Bug: b/293936429
FYI: @ZiJieHe
Pre-launch Checklist
///).