Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix incorrect FML_VLOG() severity usage #50118

Merged
mbrase merged 1 commit into from
Jan 30, 2024
Merged

Fix incorrect FML_VLOG() severity usage #50118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shell/platform/fuchsia/flutter/component_v2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ const std::string& ComponentV2::GetDebugLabel() const {
}

void ComponentV2::Kill() {
FML_VLOG(-1) << "received Kill event";
FML_VLOG(1) << "received Kill event";

// From the documentation for ComponentController, ZX_OK should be sent when
// the ComponentController receives a termination request. However, if the
Expand Down Expand Up @@ -582,7 +582,7 @@ void ComponentV2::KillWithEpitaph(zx_status_t epitaph_status) {
}

void ComponentV2::Stop() {
FML_VLOG(-1) << "received Stop event";
FML_VLOG(1) << "received Stop event";

// TODO(fxb/89162): Any other cleanup logic we should do that's appropriate
// for Stop but not for Kill?
Expand Down Expand Up @@ -617,8 +617,8 @@ void ComponentV2::OnEngineTerminate(const Engine* shell_holder) {
shell_holders_.erase(found);

if (shell_holders_.empty()) {
FML_VLOG(-1) << "Killing component because all shell holders have been "
"terminated.";
FML_VLOG(1) << "Killing component because all shell holders have been "
"terminated.";
Kill();
// WARNING: Don't do anything past this point because the delegate may have
// collected this instance via the termination callback.
Expand Down
8 changes: 4 additions & 4 deletions shell/platform/fuchsia/flutter/engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ void Engine::Initialize(
ZX_ASSERT(runner_services->Connect(
memory_pressure_provider_.NewRequest()) == ZX_OK);

FML_VLOG(-1) << "Registering memorypressure watcher";
FML_VLOG(1) << "Registering memorypressure watcher";

// Register for changes, which will make the request for the initial
// memory level.
Expand Down Expand Up @@ -647,20 +647,20 @@ void Engine::Initialize(
FML_LOG(WARNING) << "Got intl Profile without locales";
}
auto message = MakeLocalizationPlatformMessage(profile);
FML_VLOG(-1) << "Sending LocalizationPlatformMessage";
FML_VLOG(1) << "Sending LocalizationPlatformMessage";
weak->shell_->GetPlatformView()->DispatchPlatformMessage(
std::move(message));
};

FML_VLOG(-1) << "Requesting intl Profile";
FML_VLOG(1) << "Requesting intl Profile";

// Make the initial request
intl_property_provider_->GetProfile(get_profile_callback);

// And register for changes
intl_property_provider_.events().OnChange = [this, runner_services,
get_profile_callback]() {
FML_VLOG(-1) << fuchsia::intl::PropertyProvider::Name_ << ": OnChange";
FML_VLOG(1) << fuchsia::intl::PropertyProvider::Name_ << ": OnChange";
runner_services->Connect(intl_property_provider_.NewRequest());
intl_property_provider_->GetProfile(get_profile_callback);
};
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/flutter/tests/integration/embedder/flutter-embedder-test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class FlutterEmbedderTest : public ::loop_fixture::RealLoop,
public:
FlutterEmbedderTest()
: realm_builder_(component_testing::RealmBuilder::Create()) {
FML_VLOG(-1) << "Setting up base realm";
FML_VLOG(1) << "Setting up base realm";
SetUpRealmBase();

// Post a "just in case" quit task, if the test hangs.
Expand Down