This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936
Merged
Merged
[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ddcdd9e
Add new target + configuration
camsim99 600a3dd
Mark new task as bringup: true
camsim99 ea09d9e
Run in presubmit for testing
camsim99 e9238c1
Update linux_android_emulator_33.json
camsim99 e59c2c9
Remove testing change
camsim99 369567a
Merge branch '33v34_task' of github.com:camsim99/engine into 33v34_task
camsim99 dd40907
Merge branch 'main' into 33v34_task
camsim99 c13be0a
Update .ci.yaml
camsim99 5f0126b
Rename
camsim99 6e8f612
Merge branch '33v34_task' of github.com:camsim99/engine into 33v34_task
camsim99 d12dc9f
Delete unused test
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| { | ||
| "builds": [ | ||
| { | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Linux", | ||
| "kvm=1", | ||
| "cores=8" | ||
| ], | ||
| "gn": [ | ||
| "--android", | ||
| "--android-cpu=x64", | ||
| "--no-lto", | ||
| "--rbe", | ||
| "--no-goma" | ||
| ], | ||
| "name": "android_debug_x64", | ||
| "ninja": { | ||
| "config": "android_debug_x64", | ||
| "targets": [ | ||
| "flutter/shell/platform/android:flutter_shell_native_unittests", | ||
| "flutter/testing/scenario_app" | ||
| ] | ||
| }, | ||
| "tests": [ | ||
| { | ||
| "language": "python3", | ||
| "name": "Android Unit Tests", | ||
| "test_dependencies": [ | ||
| { | ||
| "dependency": "android_virtual_device", | ||
| "version": "33" | ||
| } | ||
| ], | ||
| "contexts": [ | ||
| "android_virtual_device" | ||
| ], | ||
| "script": "flutter/testing/run_tests.py", | ||
| "parameters": [ | ||
| "--android-variant", | ||
| "android_debug_x64", | ||
| "--type", | ||
| "android" | ||
| ] | ||
| }, | ||
| { | ||
| "language": "bash", | ||
| "name": "Scenario App Integration Tests", | ||
| "test_dependencies": [ | ||
| { | ||
| "dependency": "android_virtual_device", | ||
| "version": "33" | ||
| } | ||
| ], | ||
| "contexts": [ | ||
| "android_virtual_device" | ||
| ], | ||
| "script": "flutter/testing/scenario_app/run_android_tests.sh", | ||
| "parameters": [ | ||
| "android_debug_x64" | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Linux", | ||
| "kvm=1", | ||
| "cores=8" | ||
| ], | ||
| "gn": [ | ||
| "--android", | ||
| "--android-cpu=x86", | ||
| "--no-lto", | ||
| "--rbe", | ||
| "--no-goma" | ||
| ], | ||
| "name": "android_debug_x86", | ||
| "ninja": { | ||
| "config": "android_debug_x86", | ||
| "targets": [ | ||
| "flutter/shell/platform/android:flutter_shell_native_unittests" | ||
| ] | ||
| }, | ||
| "tests": [ | ||
| { | ||
| "language": "python3", | ||
| "name": "Android Unit Tests (API 28)", | ||
| "test_dependencies": [ | ||
| { | ||
| "dependency": "android_virtual_device", | ||
| "version": "28" | ||
| } | ||
| ], | ||
| "contexts": [ | ||
| "android_virtual_device" | ||
| ], | ||
| "script": "flutter/testing/run_tests.py", | ||
| "parameters": [ | ||
| "--android-variant", | ||
| "android_debug_x86", | ||
| "--type", | ||
| "android" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need to be 33 or is this meant to be 28?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's purposely 28 but we probably don't need this test for the purposes of this task so I will delete it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no problem! Just making sure.